Manushak Keramyan

Results 13 comments of Manushak Keramyan

> Hi @manushak thanks for working on this but it doesn't meet the issue spec. The plugin should be generic, by which I mean it should interpolate any arbitrary data...

Here is the specification doc of the plugin. I've attempted to compose a comprehensive document so anyone who can read it can implement it. @jawache and @jmcook1186 could you please...

@jawache This new interpolation plugin performs the calculation you mentioned: it calculates interpolation using a specified method, multiplies by the `cpu/thermal-design-power` if provided, then multiplies the result by the duration...

@jawache I've updated the spec doc, could you please verify it? (it is very massive, which is why I don't write here) https://docs.google.com/document/d/1j6VqeB4ibhf0Hp0UxsLL_k8uSD6qXh4eCXzzkEa-ees/edit?usp=sharing

> [@manushak](https://github.com/manushak) please check your PR still conforms to the issue requirements (they changes after your original PR was raised) There are small changes to make. Currently, I'm working on...

> @manushak please review the PR done

@jmcook1186, can we change the flags? The `-m` flag would refer to the manifest file, and the `-f` ( or `-d`) to the folder (either --directory or --dir). I think...

@jmcook1186 Should I add a command like `-m` in this `if-env /path/to/.yml` to be consistent with the other command line tools?

@jmcook1186, what is the difference between `if-env /path/to/.yml` and `if-env /path/to/.yml --install`? If there isn't a package.json in the first case (if-env /path/to/.yml), it should give an error. It wouldn't...

@jmcook1186 The `manifest.yml` template file is not an executed manifest file. However, we require an executed manifest file from the user. Should we provide an executed manifest template?