username-availability-checker icon indicating copy to clipboard operation
username-availability-checker copied to clipboard

Add support for disqus

Open seeeturtle opened this issue 7 years ago • 7 comments

seeeturtle avatar Mar 24 '18 07:03 seeeturtle

@manu-chroma, it seems disqus refuse user-agent of requests. I'll merge it after the PR that uses Session is merged.

seeeturtle avatar Mar 25 '18 14:03 seeeturtle

@manu-chroma , It seems User-Agent isn't the only one to get the real content from disqus...

And I can't understand why medium test fails.

seeeturtle avatar Mar 28 '18 15:03 seeeturtle

oh man, this is disappointing

manu-chroma avatar Mar 28 '18 19:03 manu-chroma

i think our safe bet is to drop medium avatar support to be honest.

it doesn't seem worth so much effort

manu-chroma avatar Mar 28 '18 19:03 manu-chroma

@manu-chroma , yeah, medium is too unpredictable... we should support medium avatar if there is way to get avatar url constantly...

btw, I think we should split the get_avatar_test to

  1. no image found
  2. returns different url.(the requests should be sent more than 2)

seeeturtle avatar Mar 29 '18 14:03 seeeturtle

I think the basic solution is to use api to provide constant result...(if we can)

seeeturtle avatar Mar 29 '18 14:03 seeeturtle

:thinking: I think I saw wrong thing. There's no error from medium. It's working well.

But still it's true that the basic solution is using api.

seeeturtle avatar Mar 29 '18 14:03 seeeturtle