source-integration icon indicating copy to clipboard operation
source-integration copied to clipboard

Project specific email notifications does not work with source-integration

Open libregeek opened this issue 13 years ago • 11 comments

Source Control Integration Plugin does not respect the custom email notifications configured for a particular project.

For example, consider a project has an Email Notification Configuration which allows all the Developers(role) to receive email notifications when an issue is Resolved. The notifications are NOT sent to Developers and only the reporter and administrators receives the notification.

However, the notifications are sent to Developers when an issue is resolved through the Mantis Web Interface.

libregeek avatar Jul 20 '12 05:07 libregeek

The bug_resolve() API function handles e-mail notifications (and twitter), however source integration assigns the status of the bug directly rather than using this API. I'll take a look at what's required to address this.

bright-tools avatar Oct 27 '15 22:10 bright-tools

Thanks for looking into it.

dregad avatar Oct 28 '15 14:10 dregad

@degrad, the change to address this and #80 are both in the same area. If you can let me know whether you're happy to merge #80 or not, I'll base the change either on that or the current code.

bright-tools avatar Nov 08 '15 21:11 bright-tools

@bright-tools I just pushed a fix for #80, so if you'd like to propose a solution for this based on current master branch, it would be great.

dregad avatar Jan 01 '17 01:01 dregad

@dregad I will take a look.

bright-tools avatar Jan 27 '17 18:01 bright-tools

@bright-tools have you been able to make any progress on this ?

dregad avatar Feb 21 '17 11:02 dregad

ping @bright-tools

dregad avatar Jun 10 '17 23:06 dregad

@dregad Would you mind taking a quick look at https://github.com/bright-tools/source-integration/tree/iss22 ? I've not yet tested it, but I'd like your opinion on whether you're satisfied with the approach. Cheers!

bright-tools avatar Sep 16 '17 13:09 bright-tools

@bright-tools it looks good to me, although I haven't actually tested the code. I would just rename $t_resolved to $t_resolve to follow the same semantics as $t_update (reflecting the fact that it's an action to take, vs a state)

dregad avatar Sep 17 '17 07:09 dregad

@dregad Thanks. I'll rename & so long as it looks generally OK, I'll do some testing before I submit a PR.

bright-tools avatar Sep 17 '17 13:09 bright-tools

@bright-tools Any progress on your testing ?

dregad avatar Jan 14 '18 17:01 dregad