mantid
mantid copied to clipboard
Fix excessive text elision workbench data view
Description of work.
This work addresses the issues with excessive text elision in the matrixworkspace data view after upgrading to Qt 5.12. See the screenshot in the linked issue for a comparison where the old version is on Qt 5.9.
It is not clear that this is a bug in Qt, just a change in behaviour. Here we introduce a delegate to control the amount of elision of the string that occurs.
To test:
- Open workbench
- Load any data file
- Show the data and most digits after the decimal point should be shown. Widen the column to show everything.
- Also check the background colours are respected. Run
MaskDetectorsand mask out several rows. Open the data view again and see the masked rows have a grey background color - Check the monitor background is colored yellow. Run
LoadEmptyInstrumentwithInstrumentName=IRIS. The first two rows in the data view should have a yellow background
Fixes #34101
Reviewer
Please comment on the following (full description):
Code Review
- Is the code of an acceptable quality?
- Does the code conform to the coding standards?
- Are the unit tests small and test the class in isolation?
- If there is GUI work does it follow the GUI standards?
- If there are changes in the release notes then do they describe the changes appropriately?
- Are the release notes saved in a separate file, using Issue or PR number for file name and in the correct location?
Functional Tests
- Do changes function as described? Add comments below that describe the tests performed?
- Do the changes handle unexpected situations, e.g. bad input?
- Has the relevant (user and developer) documentation been added/updated?
Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.