django-rest-framework-docs icon indicating copy to clipboard operation
django-rest-framework-docs copied to clipboard

Bugfix: an endpoint without a parent contaminated with its predecessor's parent.

Open rczajka opened this issue 9 years ago • 2 comments

The /another-login/ endpoint only worked correctly, because it was preceded by a pattern with an empty parent. Had the previous parent been not empty (as in the amended test), the last pattern would've been rendered as /router/another-login/, because of the parent_pattern variable reuse in the fixed loop.

rczajka avatar Jul 29 '16 14:07 rczajka

@rczajka you patch is too complex, introduces several features. I prefer to have one feature per PR. It seems to be part #125 , part #117 . Could you confirm?

StyXman avatar Dec 20 '16 18:12 StyXman

Yes. Other than the PRs you referenced, there's one-line change in 089f75418be439ed8d8b7359a5a901805cf13618, which adds .accept("json") to APIRequest, which is important if JSON isn't the API's default format.

rczajka avatar Dec 28 '16 13:12 rczajka