gImageReader icon indicating copy to clipboard operation
gImageReader copied to clipboard

not add space character for CJK.

Open napasa opened this issue 7 years ago • 12 comments
trafficstars

napasa avatar Jun 22 '18 07:06 napasa

It is not necessary to open a new PR every time, just push new commits to your branch, the PR will get updated automatically.

manisandro avatar Jun 22 '18 07:06 manisandro

Thanks.I try to rebase my new commit on top of your current master. and check whether the PR will get updated automatically.

napasa avatar Jun 22 '18 08:06 napasa

Please open one PR per feature

manisandro avatar Jun 25 '18 09:06 manisandro

How to open one PR per feature

napasa avatar Jun 25 '18 09:06 napasa

Make one branch per feature

manisandro avatar Jun 25 '18 09:06 manisandro

why not github give a button to split PR

napasa avatar Jun 25 '18 09:06 napasa

Because it would have to create two separate branches anyways to satisfy the git workflow, so you can just as well create the branches yourself.

manisandro avatar Jun 25 '18 10:06 manisandro

you are right

napasa avatar Jun 26 '18 06:06 napasa

Could you answer the question from PR #351:

So as I understand, you decide to add a space between to words if Utils::SpacedWord returns true for both the left and the right word. But Utils::SpacedWord only checks the first character of a word. Does this make sense? Isn't it better to determine whether to add a space based on the last character of the left word and the first character of the right word (in the case of left-to-right text)?

manisandro avatar Jun 27 '18 21:06 manisandro

Yes, you are right. I have changed the detect method as you said, determined it based on the last character of the left-word and the first character of the right word.

napasa avatar Jun 29 '18 08:06 napasa

There are still many uneeded spaces.

YangtseSu avatar Mar 31 '20 13:03 YangtseSu

What's the status of this PR? Looks like it hasn't been active for 3 years...

dogtopus avatar Aug 17 '23 01:08 dogtopus