Publishing a new version?

[timoschlueter]

Are there plans on publishing a new version of this plugin to the NPM registry? Our builds started to fail when we moved to [email protected] and gradle 7. I noticed that this plugin has been made gradle 7 comaptible in #203. In order to use the plugin we need a new version published to the public npm registry. Are there any plans on doing so in the near future?

[NathanWalker]

@manijak Let us know if we can help? We can bring the plugin under scope if you're okay with that? With your approval we can attribute you as primary author and give you Admin rights over here where we can work collectively on it more: https://github.com/nstudio/nativescript-plugins/pull/76#issuecomment-1067499581

[asharghi]

Bumping this @manijak

[manijak]

Sorry about the ghosting guys. Been a very busy time for me lately. I've contacted @NathanWalker on discord in regards to this. Would be best if the plugin was maintained by NS team.

[NathanWalker]

Thanks @manijak @asharghi @timoschlueter we have published @nstudio/[email protected] Source managed here now: https://github.com/nstudio/nativescript-plugins/tree/main/packages/nativescript-carousel

[asharghi]

That's great @NathanWalker! Do we need to move the https://github.com/manijak/DKCarouselView also since it's refrenced in the Pod file in the ios folder? And just curious to why this isn't under community plugins

[timoschlueter]

@manijak no worries. i think we all have been there at some point. Glad that your awesome plugin can be kept alive by the NS team! :)

@NathanWalker awesome! just tested version 8.0.0 but there seems to be a missing export: index.d.ts. The package published to NPM looks a bit strange. The new nstudio repo on GitHub has the required index.d.ts which also exports the "Carousel" Element (we are using Angular) but its missing from the package published to the npm registry. I manually checked the node_modules folder from my app:

I first noticed the problem when my IntelliJ had issues with automatic imports:

Platform specific imports don't seem to be right in our global app.module.ts. We are using a private npm proxy registry but i also invalidated the cache there and pulled the plugin again. Still looks incomplete. Do you have any idea what might have gone wrong?

[timoschlueter]

Just to make sure our proxy registry is not causing the problem i downloaded the published .tgz file directly from npm (https://registry.npmjs.org/@nstudio/nativescript-carousel/-/nativescript-carousel-8.0.0.tgz).

The content looks like this:

Really looks as if the index.d.ts (https://github.com/nstudio/nativescript-plugins/blob/main/packages/nativescript-carousel/index.d.ts) is missing. That explains why the imports are failing. Or am i completely off track here? :D

[NathanWalker]

Ah yes I’ll fix that this morning - will ping back once patch is up.

[NathanWalker]

8.0.1 published now, lemme know if further issue.

[jimmyrolando]

I just tried to run a new project with NS Vue TS blank, just adding @nstudio/nativescript-carousel and I getting this:

➜ test-corousel git:(master) ✗ ns run android --emulator Searching for devices... Preparing project... webpack is watching the files... assets by path .js 7.4 MiB asset vendor.js 6.97 MiB [compared for emit] (name: vendor) (id hint: defaultVendor) asset bundle.js 355 KiB [compared for emit] (name: bundle) asset runtime.js 86.5 KiB [compared for emit] (name: runtime) assets by path fonts/.ttf 374 KiB asset fonts/fa-solid-900.ttf 204 KiB [compared for emit] [from: app/fonts/fa-solid-900.ttf] [copied] asset fonts/fa-brands-400.ttf 131 KiB [compared for emit] [from: app/fonts/fa-brands-400.ttf] [copied] asset fonts/fa-regular-400.ttf 39.1 KiB [compared for emit] [from: app/fonts/fa-regular-400.ttf] [copied] Entrypoint bundle 7.4 MiB = runtime.js 86.5 KiB vendor.js 6.97 MiB bundle.js 355 KiB runtime modules 24.8 KiB 12 modules orphan modules 356 bytes [orphan] 6 modules modules by path ./node_modules/ 2.64 MiB 323 modules modules by path ./app/ 128 KiB modules by path ./app/components/*.vue 5.23 KiB ./app/components/Home.vue 1.17 KiB [built] [code generated] ./app/components/Home.vue?vue&type=template&id=1858554c&scoped=true& 214 bytes [built] [code generated] + 5 modules ./app/app.ts 3.19 KiB [built] [code generated] ./app/app.scss 119 KiB [built] [code generated] external "~/package.json" 42 bytes [optional] [built] [code generated] webpack 5.70.0 compiled successfully in 2255 ms Webpack compilation complete. Watching for file changes. No issues found. File change detected. Starting incremental webpack compilation... Updating runtime package.json with configuration values... Project successfully prepared (android) Building project... Gradle build... assets by status 7.77 MiB [cached] 6 assets Entrypoint bundle 7.4 MiB = runtime.js 86.5 KiB vendor.js 6.97 MiB bundle.js 355 KiB cached modules 2.77 MiB (javascript) 24.8 KiB (runtime) [cached] 351 modules webpack 5.70.0 compiled successfully in 64 ms Webpack compilation complete. Watching for file changes. No issues found. + applying user-defined configuration from /Users/jimmy/Codebase/test-corousel/App_Resources/Android/before-plugins.gradle + setting applicationId + applying user-defined configuration from /Users/jimmy/Codebase/test-corousel/App_Resources/Android/before-plugins.gradle + applying user-defined configuration from /Users/jimmy/Codebase/test-corousel/App_Resources/Android/app.gradle + adding nativescript runtime package dependency: nativescript-optimized-with-inspector + adding aar plugin dependency: /Users/jimmy/Codebase/test-corousel/node_modules/@nativescript/core/platforms/android/core.aar + adding aar plugin dependency: /Users/jimmy/Codebase/test-corousel/node_modules/@nativescript/core/platforms/android/widgets-release.aar

Build file '/Users/jimmy/Codebase/test-corousel/platforms/android/app/build.gradle' line: 575 A problem occurred configuring project ':app'. Could not find com.romandanylyk:pageindicatorview:1.0.3. Required by: project :app

Unable to apply changes on device: emulator-5554. Error is: Command ./gradlew failed with exit code 1.

====

any body is getting same error, thanks

I'm on a Mac M1, I'm using:

Android Studio Bumblebee | 2021.1.1 Patch 2 Build #AI-211.7628.21.2111.8193401, built on February 17, 2022 Runtime version: 11.0.11+0-b60-7772763 aarch64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. macOS 12.3 GC: G1 Young Generation, G1 Old Generation Memory: 2048M Cores: 10 Registry: external.system.auto.import.disabled=true Non-Bundled Plugins: org.jetbrains.kotlin (211-1.6.10-release-923-AS7442.40)

[jimmyrolando]

I realize is something about the com.romandanylyk:pageindicatorview:1.0.3 repository, I put jcenter in app.gradle and it works

[NathanWalker]

Thanks for confirming @jimmyrolando we can probably specify jcenter in the plugins include.gradle

[NathanWalker]

@jimmyrolando fixed with @nstudio/[email protected] now. Added jcenter in plugin itself: https://github.com/nstudio/nativescript-plugins/commit/68a70e9a29f3a5d9eb1d38b6d0826993c71b57bf

[grigala]

I realize is something about the com.romandanylyk:pageindicatorview:1.0.3 repository, I put jcenter in app.gradle and it works

Thanks for confirming @jimmyrolando we can probably specify jcenter in the plugins include.gradle

@jimmyrolando fixed with @nstudio/[email protected] now. Added jcenter in plugin itself: nstudio/nativescript-plugins@68a70e9

I don't think that's a good idea boys. As far as I know, dependencies from JCenter can no longer be resolved as of 01.02.2022. You should actually see a warning in your IDE as well: Builds will no longer be able to resolve artifacts from JCenter after February 1st, 2022.

It should be pulled from maven { url 'https://jitpack.io' } instead, I suppose (or mavenCentral() if it exists there?).

See this.

Anyway, @NathanWalker thanks for the release.

[NathanWalker]

Thanks @grigala we can update that to best reference - I’ll be honest between bintray and jcenter it got quite confusing; if you know the best reference post here and we’ll switch to that.

[NathanWalker]

@grigala published 8.0.3 with these settings shich should be better for longevity:

allprojects {
    repositories {
      maven { url "https://jitpack.io" }
    }
}
dependencies {
  implementation 'com.github.romandanylyk:PageIndicatorView:b1bad589b5'
}

Let me know if anyone else has further trouble.