maniac103

Results 230 comments of maniac103

> That said, how about adding a "clear cache" option below "add reaction" in issues ? That seems a bit strong handed, given that kind of issue is pretty rare.

Yeah, that would make sense, but what I'm not convinced on yet is the use case: why would on want to create an (empty) repo on mobile when one can't...

@Tunous I think this one is for you ;-) It's a NPE here: https://github.com/slapperwan/gh4a/blob/master/app/src/main/java/com/gh4a/loader/PullRequestCommentListLoader.java#L79

@Tunous I think I'd prefer displaying a short summary ('Tunous reviewed on xxx\nCode comments in file yyy, zzz\nShow details') and show the details in a separate event list fragment in...

Looks good. I assume the big green 'diff' block is a placeholder?

> Maybe a good idea for frame at least. Not sure. In the case of the Android app, a frame is rendered just as a title bar. I don't see...

For setpoints (and roller shutters), it's only a detail view, the up/down buttons are the default. https://github.com/openhab/openhab-android/issues/3247 has a screenshot of it. For that reason, I'd keep those two items...

> So the default should be a behaviour that will work for all use cases. How about my option 3 mentioned above?