windows-nt-vscode-theme icon indicating copy to clipboard operation
windows-nt-vscode-theme copied to clipboard

Poor contrast with scm state in file explorer

Open connor4312 opened this issue 4 years ago • 7 comments

VS Code highlights files with different colors when they're ignored, modified, added, or removed in scm/git. These colors could use a little tweaking:

connor4312 avatar Jul 07 '21 18:07 connor4312

Thank @connor4312 for filling this issue.

I did few tests. Would the following color palette work?

image

manekinekko avatar Jul 07 '21 22:07 manekinekko

Looks great! I would still prefer something else for the "ignored" folder though, reading it is painful. Maybe the same or a slightly darker grey than the activity bar icons?

connor4312 avatar Jul 07 '21 23:07 connor4312

What about this palette?

image

manekinekko avatar Jul 08 '21 07:07 manekinekko

Is there a reason why icon.foreground was set to white? Those seem to stand out as low contrast after these changes. You can also set the icon colors when an item is selected via list.activeSelectionIconForeground

miguelsolorio avatar Jul 08 '21 16:07 miguelsolorio

The problem is when hovering over a list of items, the icons in black are not readable at all.

image

The list.activeSelectionIconForeground options only set the icon color when the selection is active:

image

manekinekko avatar Jul 08 '21 20:07 manekinekko

@manekinekko Adding to this, this is how it looks on Windows image

Typography seems to be thinner on Windows and the pink / magenta for untracked files is a bit hard to read. Will make sure it's not related to any setting I have and will try to fix this myself when I have the chance!

leninnava avatar Jan 16 '24 01:01 leninnava

Thanks for the update @leninnava. Happy to review any PR you will submit.

manekinekko avatar Jan 16 '24 07:01 manekinekko