VM-Packages icon indicating copy to clipboard operation
VM-Packages copied to clipboard

Update CyberChef to use CyberChef icon

Open emtuls opened this issue 1 year ago • 8 comments

This converts the CyberChef PNG file that is provided with the download and converts it to a .ico so that Chocolatey can use it for an icon for the shortcut.

Closes https://github.com/mandiant/VM-Packages/issues/966

emtuls avatar May 23 '24 19:05 emtuls

@emtuls :eyes:

Ana06 avatar Jun 18 '24 11:06 Ana06

@mandiant/flare-vm Any preference or thoughts on which icon to use for Cyberchef? One icon uses the robot-chef mix. It looks good on taskbar and on the desktop but has a slight blurry look when viewed in the Tools folder in small/detail view. cyberchef image

The other icon is just a Chef hat (also provided by Cyberchef as a .ico, so not a random chef hat), which looks a little better in small/detail view, but I personally think it looks a bit blurry when viewed on Desktop and the Taskbar. image image

Another thing to note is that the Robot-Chef mix icon requires some additional code to convert an image file to a .ico file.

emtuls avatar Jul 08 '24 17:07 emtuls

@d35ha can you test this locally and share your opinion on this? :smile:

Ana06 avatar Jul 25 '24 17:07 Ana06

@stevemk14ebr @mr-tz @binjo @d35ha any preference on the icon? The icons look a bit different (see screenshots in the previous comments). @emtuls prefers to generate Robot-Chef icon (requires some additional code to convert an image file to a .ico file), while I prefer the Chef hat.

Ana06 avatar Aug 26 '24 09:08 Ana06

I don't mind either, I vote for whichever is easiest to maintain

stevemk14ebr avatar Aug 27 '24 13:08 stevemk14ebr

I don't mind either, I vote for whichever is easiest to maintain

I second this. FWIW taskbars may be configured in other colors (mine is black). I agree that gray on gray is a bit hard to see.

mr-tz avatar Aug 29 '24 07:08 mr-tz

I think the Chef hat is easier to maintain because it requires less code. But as it seems nobody else has a strong opinion, I'll let @emtuls decide. @emtuls can you please rebase the final version so that we can merge this change? :smile:

Ana06 avatar Aug 29 '24 09:08 Ana06

After googling CyberChef and seeing most websites/videos use the Robot-Chef icon, I'm inclined to keep that style for now. :)

emtuls avatar Sep 13 '24 21:09 emtuls