Travis-Encrypt icon indicating copy to clipboard operation
Travis-Encrypt copied to clipboard

Merging efforts with TravisPy

Open Midnighter opened this issue 8 years ago • 7 comments

Currently, I have need of exactly the functionality that your package provides. However, I also need further interaction with Travis which is why I'm using TravisPy and have an open issue there https://github.com/menegazzo/travispy/issues/51. I was wondering if there is any interest from your side of merging your package's functionality into TravisPy?

Midnighter avatar Jun 28 '17 13:06 Midnighter

Thanks for letting me know about TravisPy. I think my desired course of action is to create an API for Travis-Encrypt that can be used by other applications such as TravisPy. I'll work on that tonight and hope to release a new version of Travis-Encrypt soon after.

mandeep avatar Jun 28 '17 18:06 mandeep

Cool, I'm just calling your two functions directly at the moment but, of course, it'd be nice to have it come from one package integrated with all the other Travis functionality.

Midnighter avatar Jun 29 '17 08:06 Midnighter

Would you be willing to submit a PR to TravisPy to include those two functions?

mandeep avatar Jun 29 '17 14:06 mandeep

I definitely thought about it. Since my current setup works, though, my motivation is not super high ;) and the TravisPy design seems a little strange to me.

Midnighter avatar Jun 30 '17 07:06 Midnighter

No worries. I'll see if I can get to it this weekend.

mandeep avatar Jun 30 '17 13:06 mandeep

@Midnighter could you show me an example of how you'd like to use Travis-Encrypt within TravisPy?

mandeep avatar Aug 12 '17 17:08 mandeep

You can see what I'm currently doing here: https://github.com/opencobra/memote/blob/a0818f7010dfa253424a9fc57f6566cc248e107f/memote/suite/runner.py#L385-L452 and to be honest it works for me. I encrypt a variable and put it in the .travis.yml. It could be useful to exploit the Travis API interaction that TravisPy provides to directly upload the variable to the repository rather than using the .travis.yml.

Midnighter avatar Aug 12 '17 21:08 Midnighter