youtube-dl-server icon indicating copy to clipboard operation
youtube-dl-server copied to clipboard

Bookmarklet doesn't work on docker

Open jacob2020baklas opened this issue 1 year ago • 4 comments
trafficstars

the bookmarklet produced http request does't go past the browser image

i think it needs ssl support now it uses vpn and im not sure how to configure it behind my proxy PS: everything else works as expected (UI & Download)

jacob2020baklas avatar Jan 25 '24 18:01 jacob2020baklas

Update : i modified the CMD which starts the unicorn server and rerun the container with docker compose

  • i added --certfile and private key arguments this enabled ssl support but the CORS problem still an issue because starlette-middleware class is missing to solve this we need to add https://www.starlette.io/middleware/#corsmiddleware

jacob2020baklas avatar Jan 25 '24 22:01 jacob2020baklas

yeah its been a long time since I tried the bookmarklet... I don't think adding the CORS middleware to starlette will fix that issue. I think adding that middleware would just allow you to load resources from other domains when on the youtube-dl ui. You might just need to use one of the browser extensions that let you toggle CORS on a page.

manbearwiz avatar Jan 26 '24 04:01 manbearwiz

try this? https://github.com/balvin-perrie/Access-Control-Allow-Origin---Unblock

manbearwiz avatar Jan 26 '24 04:01 manbearwiz