plane icon indicating copy to clipboard operation
plane copied to clipboard

feat: Arabic language support

Open khalilzitouni2058 opened this issue 7 months ago β€’ 5 comments

Description

This PR includes following language support:

Arabic

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Feature (non-breaking change which adds functionality)
  • [ ] Improvement (change that would cause existing functionality to not work as expected)
  • [ ] Code refactoring
  • [ ] Performance improvements
  • [ ] Documentation update

Screenshots and Media (if applicable)

Test Scenarios

image

References

[WEB-3732 | WEB-3731]

Summary by CodeRabbit

  • New Features
    • Added Arabic language support to broaden available language options.
    • Integrated Arabic translations for a more localized user experience.

khalilzitouni2058 avatar Apr 03 '25 15:04 khalilzitouni2058

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 03 '25 15:04 CLAassistant

Walkthrough

This pull request introduces support for the Arabic language in the application's internationalization module. The update adds Arabic as an option in the supported languages constant and extends the type definition to include the "ar" value. In addition, the translation store method is modified to import the Arabic translations JSON file when the Arabic language is selected.

Changes

File(s) Change Summary
packages/i18n/src/constants/language.ts
packages/i18n/src/types/language.ts
Added Arabic language entry: updated SUPPORTED_LANGUAGES to include { label: "Arabic", value: "ar" } and extended the TLanguage type to support "ar".
packages/i18n/src/store/index.ts Introduced a new case in the importLanguageFile method to load Arabic translations from ../locales/ar/translations.json when the language code "ar" is requested.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant S as TranslationStore
    participant FS as File System

    U->>S: Request translations for "ar"
    S->>FS: Import ../locales/ar/translations.json
    FS-->>S: Return Arabic translations
    S-->>U: Provide Arabic translations

Poem

Oh, how I hop with glee,
A new language for you and me!
"Arabic" now joins our crew,
With translations fresh and true.
Hoppity hops and a cheerful cheer,
CodeRabbit smiles as changes appear!
πŸ‡βœ¨


πŸ“œ Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between d62ac6269b0e908780baf7928a7cc8cd664a32e5 and 149a5af5f31516a3238d1a12cfcab2fc6db6f25d.

πŸ“’ Files selected for processing (3)
  • packages/i18n/src/constants/language.ts (1 hunks)
  • packages/i18n/src/store/index.ts (1 hunks)
  • packages/i18n/src/types/language.ts (1 hunks)
πŸ”‡ Additional comments (3)
packages/i18n/src/types/language.ts (1)

19-20: LGTM! Successfully added Arabic language support to the type definition.

The addition of "ar" to the TLanguage type is correctly implemented, maintaining the same pattern as the existing language codes.

packages/i18n/src/constants/language.ts (1)

24-24: LGTM! Arabic language option correctly added to supported languages.

The addition of Arabic to the SUPPORTED_LANGUAGES constant follows the established pattern, with proper label ("Arabic") and value ("ar").

packages/i18n/src/store/index.ts (1)

176-177:

βœ… Verification successful

LGTM! Arabic translations import properly implemented.

The case statement for importing Arabic translations is correctly added to the importLanguageFile method, following the same structure as other languages.


🏁 Script executed:

#!/bin/bash
# Verify that the Arabic translation file exists in the expected location

if [ -f "packages/i18n/src/locales/ar/translations.json" ]; then
  echo "βœ… Arabic translations file exists at expected location"
else
  echo "❌ Arabic translations file not found at packages/i18n/src/locales/ar/translations.json"
  echo "Please ensure the Arabic translations file is created"
  exit 1
fi

Length of output: 178


LGTM: Arabic translations import verified and implemented correctly

  • The Arabic translations file is present at packages/i18n/src/locales/ar/translations.json.
  • The import statement in packages/i18n/src/store/index.ts (lines 176-177) correctly imports the file.
✨ Finishing Touches
  • [ ] πŸ“ Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 03 '25 15:04 coderabbitai[bot]

hi @prateekshourya29 , When you get a chance, could you please take a look at my PR feat

khalilzitouni2058 avatar Apr 06 '25 11:04 khalilzitouni2058

hi @prateekshourya29 , When you get a chance, could you please take a look at my PR feat

Hey @khalilzitouni2058, thanks for the PR! Our components don’t support RTL layout yet. We’ll let you know once that’s in place so we can proceed with merging your changes.

prateekshourya29 avatar Apr 09 '25 10:04 prateekshourya29

Pull Request Linked with Plane Work Items

References

Comment Automatically Generated by Plane

makeplane[bot] avatar Apr 17 '25 11:04 makeplane[bot]