fix(webhook): allow private ip to be used as payload url

[Royalsspirit]

Hello guys,

Currently, in a self hosted plane, we cannot use any automation software hosted in a private domain.

In order to enable it, remove the statement checking if IP is private.

Feedbacks are welcome :)

Summary by CodeRabbit

• New Features

  • Updated IP address validation to allow private IP addresses, enhancing flexibility in accepted inputs.

• Bug Fixes

  • Resolved issues related to validation errors for private IP addresses, improving user experience.

[coderabbitai[bot]]

Walkthrough

The changes made in the apiserver/plane/app/serializers/webhook.py file involve an update to the IP address validation logic within the create and update methods of the serializer. The previous validation criteria, which disallowed private IP addresses, have been modified to only check for loopback addresses, allowing a broader range of IP addresses to pass validation.

Changes

Files	Change Summary
apiserver/plane/app/serializers/webhook.py	Modified IP address validation logic in create and update methods to only check for loopback addresses, allowing private IP addresses.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Serializer
    participant Validator

    User->>Serializer: Submit IP address
    Serializer->>Validator: Validate IP address
    alt Loopback address
        Validator-->>Serializer: Validation error
    else Valid IP address
        Validator-->>Serializer: No error
    end
    Serializer-->>User: Response

🐇 "In the meadow, I hop with glee,
New rules for IPs, oh, what a spree!
Loopbacks are checked, but private ones stay,
More friends to play with, hip-hip-hooray!
Hopping along, I dance in delight,
For changes like these make my day bright!" 🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[pablohashescobar]

Hi @Royalsspirit, can you please sign the CLA.

[Royalsspirit]

Hello @pablohashescobar, i think i have already signed the CLA but it's still in pending

[pablohashescobar]

@Royalsspirit, but it still shows not signed can you please check again.

[Royalsspirit]

I don't know what to say. When i go to the CLA details, it says that i have already signed it

You have agreed to the CLA for multiple repositories or organizations

And indeed, i signed it 2 months ago maybe when i opened my first PR on this repo.

Is there something that i miss ?

[sriramveeraghanta]

We will validate it once and merge this one. Thank you for your contribution.