ember-simple-auth icon indicating copy to clipboard operation
ember-simple-auth copied to clipboard

Breaking changes in 3.1

Open ef4 opened this issue 4 years ago • 2 comments

It seems that we experienced breaking changes when upgrading from 3.0 to 3.1.

This app did not use any of the route mixins, and handled all transitions on its own (we did not rely on ember-simple-auth triggering any transitions).

When trying to upgrade to 3.1, the test suite detected breakage because ember-simple-auth started issuing routing transitions that were unexpected.

Am I missing something I was supposed to do? Were those transitions supposed to be happening on 3.0 as well, but weren't for some reason?

We can eventually refactor to use this newer pattern, but had to roll back the upgrade until we can.

ef4 avatar Mar 05 '21 23:03 ef4

Same here we have some unexpected route transitions to the authentication route, we didn't experience this transitions using mixins in the 3.1.0beta.

pabloascarza avatar Mar 08 '21 18:03 pabloascarza

Is this still an issue?

BobrImperator avatar Sep 27 '21 20:09 BobrImperator

I can no longer reproduce this on ember-simple-auth 4.2.2.

ef4 avatar Mar 03 '23 22:03 ef4