mailerlite-api-v2-php-sdk icon indicating copy to clipboard operation
mailerlite-api-v2-php-sdk copied to clipboard

Published 20 hours ago • verified publisher icon mailerlite

require all necessary psr implementations

Open dbu opened this issue 3 years ago • 1 comments

the code relies on psr7, psr17 and psr18 implementations to be available, with the discovery.

it no longer uses the php-http httplug interface (which was made obsolete by psr-18). php-http/client-common is also not used in the code.

dbu avatar May 21 '22 16:05 dbu

i tried running the tests locally, but they fail because the tests assume the json is decoded to array, but RestClient::handleResponse does json_decode with false, so creating stdClass objects.

i don't think this has anything to do with the changes i propose. but it would be a good idea to fix the tests.

dbu avatar May 21 '22 16:05 dbu