magicui icon indicating copy to clipboard operation
magicui copied to clipboard

Added Background Light Component to Magic UI.

Open Gitstar-OC opened this issue 1 year ago • 3 comments

This commit solves the problem of addition of extra file package-lock.json file in this pull request. #349.

Gitstar-OC avatar Oct 01 '24 12:10 Gitstar-OC

@Gitstar-OC is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 01 '24 12:10 vercel[bot]

Why is this pull request not being accepted ?

Gitstar-OC avatar Oct 01 '24 17:10 Gitstar-OC

This repository is no longer active!! Fix this.

Gitstar-OC avatar Oct 11 '24 12:10 Gitstar-OC

Will this be merged ? Please merege it!!

Gitstar-OC avatar Oct 30 '24 03:10 Gitstar-OC

@Gitstar-OC Could you explain what this component's usecase? Additionally, could you share a short video demonstrating how the component works?

itsarghyadas avatar Dec 12 '24 16:12 itsarghyadas

@itsarghyadas #340 shows how it looks and it's usage.

Also a sidenote, I have removed the component from my website and moved to a design more suitable for an educational website.

Gitstar-OC avatar Dec 12 '24 17:12 Gitstar-OC

Unfortunately, when I tested your code locally, it didn't cover the entire background as expected. I assumed it would fill the whole area, but instead, it only displays a background behind the text, not spanning the full height and width.

itsarghyadas avatar Dec 12 '24 17:12 itsarghyadas

Wait, I think some style adjustments will solve that, I will work on it and update this with a new commit tomorrow.

Gitstar-OC avatar Dec 12 '24 17:12 Gitstar-OC

Thank you for the quick reply! I love the idea of this component and am excited to add it to MagicUI.

itsarghyadas avatar Dec 12 '24 17:12 itsarghyadas

Hey just as an update, I have worked on it but I am unable to see the component on the link after following all of the steps but my component is still not visible and shows not found.

Gitstar-OC avatar Dec 13 '24 16:12 Gitstar-OC

Yeah I guess its because <ComponentPreview name="backgroun-light-demo it should be backgroun-light-demo, check the spelling

itsarghyadas avatar Dec 13 '24 16:12 itsarghyadas

I tried changing that but the whole thing is not visible, if there is an error in the component the name and other deatils should still appear but it is not the case.

Gitstar-OC avatar Dec 13 '24 16:12 Gitstar-OC

Hey, I checked it again and found that it doesn’t work as described in https://github.com/magicuidesign/magicui/issues/340

For now, we’re closing this PR. If you come up with a fix, you’re welcome to create another PR, and we’ll be happy to review it. Thank you!

itsarghyadas avatar Dec 19 '24 05:12 itsarghyadas