magic-admin-js icon indicating copy to clipboard operation
magic-admin-js copied to clipboard

Wallets data keys is not transformed and have discrepancy with types

Open serhiislobodian opened this issue 2 years ago • 0 comments

✅ Prerequisites

  • [+] Did you perform a cursory search of open issues? Is this bug already reported elsewhere?
  • [+] Are you running the latest SDK version?
  • [+] Are you reporting to the correct repository (@magic-sdk/admin)?

🐛 Description

data.wallet keys are not transformed like the rest

https://github.com/magiclabs/magic-admin-js/blob/master/src/modules/users/index.ts#L73

Type definitions point to the address property that should be called publicAddress but in reality, it is public_address

🤔 Expected behavior

Correct type definitions.

serhiislobodian avatar Nov 08 '23 14:11 serhiislobodian