magento-2-blog icon indicating copy to clipboard operation
magento-2-blog copied to clipboard

Update Sitemap.php to fix issue #295

Open anvanza opened this issue 4 years ago • 5 comments

Description

Add the title to the images so the sitemap generation works

Fixed Issues (if relevant)

  1. https://github.com/mageplaza/magento-2-blog/issues/295 : Sitemap generation fails because of missing image info

Manual testing scenarios

  1. Create sitemap

Contribution checklist

  • [ /] Pull request has a meaningful description of its purpose
  • [ /] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)

anvanza avatar Jan 26 '21 12:01 anvanza

Can confirm that this patch works for me in 2.4.1 on Cloud.

davemyb avatar Jan 28 '21 21:01 davemyb

This patch works for 2.3.7 too. Please pull.

ci2014 avatar Mar 11 '21 18:03 ci2014

Patch works in 2.4.2-p1 and why isn't pulled?

Green2Matter avatar May 27 '21 07:05 Green2Matter

Patch works in 2.4.2-p1 and why isn't pulled?

No idea, but Mageplaza has a sitemap extension. Could be that they're trying to push that extension.

This solution worked for me but this is far from perfect. Overwriting the sitemap model like that.. A better solution would be to create a new model that imprements the Magento\Sitemap\Model\ItemProvider\ItemProviderInterface.

anvanza avatar May 27 '21 07:05 anvanza

This solution worked for me but this is far from perfect. Overwriting the sitemap model like that.. A better solution would be to create a new model that imprements the Magento\Sitemap\Model\ItemProvider\ItemProviderInterface.

Another question, is there any better blog module? :-)

Green2Matter avatar May 27 '21 15:05 Green2Matter

Hi , Thanks for your contribution. We have updated and released a new version that solves this problem. Thank you very much!

KhietNguyen83 avatar Nov 09 '22 15:11 KhietNguyen83