magento-2-blog
magento-2-blog copied to clipboard
Update Sitemap.php to fix issue #295
Description
Add the title to the images so the sitemap generation works
Fixed Issues (if relevant)
- https://github.com/mageplaza/magento-2-blog/issues/295 : Sitemap generation fails because of missing image info
Manual testing scenarios
- Create sitemap
Contribution checklist
- [ /] Pull request has a meaningful description of its purpose
- [ /] All commits are accompanied by meaningful commit messages
- [ ] All new or changed code is covered with unit/integration tests (if applicable)
Can confirm that this patch works for me in 2.4.1 on Cloud.
This patch works for 2.3.7 too. Please pull.
Patch works in 2.4.2-p1 and why isn't pulled?
Patch works in 2.4.2-p1 and why isn't pulled?
No idea, but Mageplaza has a sitemap extension. Could be that they're trying to push that extension.
This solution worked for me but this is far from perfect. Overwriting the sitemap model like that.. A better solution would be to create a new model that imprements the Magento\Sitemap\Model\ItemProvider\ItemProviderInterface.
This solution worked for me but this is far from perfect. Overwriting the sitemap model like that.. A better solution would be to create a new model that imprements the Magento\Sitemap\Model\ItemProvider\ItemProviderInterface.
Another question, is there any better blog module? :-)
Hi , Thanks for your contribution. We have updated and released a new version that solves this problem. Thank you very much!