pwa-studio
pwa-studio copied to clipboard
[bug]: fix Yarn invariant violation caused by "packages/pagebuilder" requesting different version of "react-tabs"
Describe the bug
When running yarn install, Yarn throws an invariant violation and fails to install.
I traced this down to packages/pagebuilder/package.json which defines:
"devDependencies": {
...
"react-tabs": "~3.0.0"
},
"peerDependencies": {
...
"react-tabs": "~3.1.0"
}
This breaks Yarn workspaces because it can't resolve to a single version.
Expected behavior
Yarn can install.
Possible solutions
I will submit a PR.
There isn't a breaking change between react-tabs 3.0.0 and 3.1.0. It only added LTR locale support.
The Pagebuilder package should define both dependencies with 3.1.0, so Yarn works.
Please let us know what packages this bug is in regards to:
- [ ]
venia-concept - [ ]
venia-ui - [x]
pagebuilder - [ ]
pwa-buildpack - [ ]
peregrine - [ ]
pwa-devdocs - [ ]
upward-js - [ ]
upward-spec - [ ]
create-pwa
Hi @brendanfalkowski. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this
Join Magento Community Engineering Slack and ask your questions in #github channel.
@magento I am working on this
@adobe export issue to JIRA project PWA as Bug
:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/PWA-3533 is successfully created for this GitHub issue.