pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

[bug]: fix Yarn invariant violation caused by "packages/pagebuilder" requesting different version of "react-tabs"

Open brendanfalkowski opened this issue 5 months ago • 2 comments

Describe the bug

When running yarn install, Yarn throws an invariant violation and fails to install.

I traced this down to packages/pagebuilder/package.json which defines:

"devDependencies": {
  ...
  "react-tabs": "~3.0.0"
},
"peerDependencies": {
  ...
  "react-tabs": "~3.1.0"
}

This breaks Yarn workspaces because it can't resolve to a single version.

Expected behavior

Yarn can install.

Possible solutions

I will submit a PR.

There isn't a breaking change between react-tabs 3.0.0 and 3.1.0. It only added LTR locale support.

The Pagebuilder package should define both dependencies with 3.1.0, so Yarn works.

Please let us know what packages this bug is in regards to:

  • [ ] venia-concept
  • [ ] venia-ui
  • [x] pagebuilder
  • [ ] pwa-buildpack
  • [ ] peregrine
  • [ ] pwa-devdocs
  • [ ] upward-js
  • [ ] upward-spec
  • [ ] create-pwa

brendanfalkowski avatar Jun 20 '25 21:06 brendanfalkowski

Hi @brendanfalkowski. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information. Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Jun 20 '25 21:06 m2-assistant[bot]

@magento I am working on this

brendanfalkowski avatar Jun 20 '25 21:06 brendanfalkowski

@adobe export issue to JIRA project PWA as Bug

glo82145 avatar Jul 17 '25 07:07 glo82145

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/PWA-3533 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Jul 17 '25 07:07 github-jira-sync-bot