pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

It seems that the poster for the video does not update when the video ID is changed. This could lead to confusion for users.

Open arvind-netzwelt opened this issue 1 year ago • 3 comments

Describe the bug

A clear and concise description of what the bug is.

To reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior I have used Venia PWA with Magento 2. I have used React-player to show a YouTube video. If I change the YouTube video in Magento, the poster of the video does not change. However, in GraphQL, the ID of the video is changed. How can this be handled?

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Possible solutions

Add any ideas about possible solutions to the problem here.

Debug Report

Paste the output of yarn build:report, and any other context about the problem, here.

Please complete the following device information:

  • Device [e.g. iPhone6, PC, Mac, Pixel3]:
  • Browser [e.g. Chrome, Safari]:
  • Browser Version [e.g. 22]:
  • Magento Version [e.g Adobe Commerce 2.4]:

Please let us know what packages this bug is in regards to:

  • [ ] venia-concept
  • [ ] venia-ui
  • [ ] pwa-buildpack
  • [ ] peregrine
  • [ ] pwa-devdocs
  • [ ] upward-js
  • [ ] upward-spec
  • [ ] create-pwa

arvind-netzwelt avatar Aug 14 '24 04:08 arvind-netzwelt

Hi @arvind-netzwelt. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information. Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Aug 14 '24 04:08 m2-assistant[bot]

@adobe export issue to JIRA project PWA as Bug

glo82145 avatar Sep 23 '24 08:09 glo82145

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/PWA-3357 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Sep 23 '24 08:09 github-jira-sync-bot

@arvind-netzwelt hi, we'd like more information on this issue. We tried to add a video to the PWA venia-storefront using Magento Admin pagebuilder. We then replaced the first video URL with a new one and refreshed the cache from Magento admin and then checked the PWA-frontend and the Banner updated correctly for us.

Do you have any specific steps to recreate the issue ?

del15881 avatar Oct 24 '24 06:10 del15881

I have added the code like this, youtubeCaption changed on Graphql but not changed on frontend. after clear the browser cookies its working fine

<ReactPlayer key={${youTubeUrl}-${youtubeCaption}} width="100%" height={isDesktop ? '400px' : '200px'} url={youTubeUrl} playing={playing} className={classes.modalVideo} controls={false} light={youtubeCaption || true} playIcon={ <PlayPauseButton playing={playing} handlePlayPause={handlePlayPause} /> } />

arvind-netzwelt avatar Oct 24 '24 07:10 arvind-netzwelt

Hey @arvind-netzwelt , Thank you for your response. As part of our current process, we are unable to accommodate requests for custom code changes directly. However, we welcome and encourage contributions from community members who are interested in supporting code enhancements.

del15881 avatar Oct 25 '24 07:10 del15881

As per our process, this issue has remained inactive with no updates or inputs for over two weeks. Therefore, we are closing it. However, if any community member is interested in contributing to this ticket, please feel free to reopen the issue.

del15881 avatar Jan 07 '25 07:01 del15881