pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

[Issue] AC-2489::Page title for search page not informative (Search Results)

Open m2-assistant[bot] opened this issue 3 years ago • 2 comments
trafficstars

This issue is automatically created based on existing pull request: magento/pwa-studio#3931: AC-2489::Page title for search page not informative (Search Results)


Description

Reproduction Steps search "short" - [NODE][body>div:nth-of-type(1)>:nth-child(1)>:nth-child(3)]

  1. Execute a site search and observe the page title in the browser tab.

Actual Behavior The search page does not have a descriptive title; its title is "Default Store View". When the page

of the document does not describe the topic or purpose of the page, users of assistive technology may have trouble finding content or orienting themselves. <p>Expected Behavior Ensure that the value for the </p><title> element is updated as the page content changes and describes the page's purpose or topic in a concise matter (e.g. "Search Results - <h2>Related Issue</h2> <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here by replacing ISSUE_NUMBER with your actual issue number. --> <!--- Using the above wording causes Github to automatically close the issue on merge. --> <p>Closes #https://jira.corp.adobe.com/browse/AC-2489</p> <h2>Acceptance</h2> <!-- The people and processes this pull request needs before it is merged. --> <!-- These fields are not required when opening the pull request, but they --> <!-- should be populated after code review. --> <h3>Verification Stakeholders</h3> <!-- People who must verify that this solves the attached issue. --> <h3>Specification</h3> <!-- Changes to `upward-spec` and/or `upward-js` packages must be reviewed --> <!-- by `UPWARD-PHP` maintainers to ensure continued compatibility --> <h2>Verification Steps</h2> <!-- During code review and QA we will try to ensure there are no bugs introduced by this change --> <!-- So, we request that you add a detailed test plan on what needs to be checked before this PR gets merged --> <!-- Feel free to update this after submitting the PR as you discover new scenarios --> <!-- As part of review/QA we may also add or update the test plan if necessary--> <h4>Test scenario(s) for direct fix/feature</h4> <!-- Examples: --> <!-- 1. Verify user is able to apply filters on category page --> <!-- 2. Verify user is able to apply filters on search page --> <h4>Test scenario(s) for any existing impacted features/areas</h4> <!-- Examples: --> <!-- Verify user is able to sort data after applying filters on category page --> <!-- Verify user is able to sort data after applying filters on search page --> <h4>Test scenario(s) for any Magento Backend Supported Configurations</h4> <!-- Examples: --> <!-- Update default Sort value in backend and repeat above scenarios --> <h4>Is Browser/Device testing needed?</h4> <!-- Example: --> <!-- Yes, browser testing is needed as X UI component may be impacted on <browser> --> <!-- Yes, device testing is needed as X UI component may be impacted on <mobile|desktop|etc> --> <h4>Any ad-hoc/edge case scenarios that need to be considered?</h4> <!-- Example: --> <!-- Apply all filters to get 0 results and then remove filters to see respective products --> <h2>Screenshots / Screen Captures (if appropriate)</h2> <h2>Breaking Changes (if any)</h2> <!-- If there are any breaking changes in this PR, please describe them here--> <!-- For example: --> <!-- * Removed Foo prop fro component Bar --> <h2>Checklist</h2> <!--- Go over all the following points, and make sure you've done anything necessary --> <ul> <li>I have added tests to cover my changes, if necessary.</li> <li>I have added translations for new strings, if necessary.</li> <li>I have updated the documentation accordingly, if necessary.</li> </ul>

m2-assistant[bot] avatar Aug 23 '22 21:08 m2-assistant[bot]

@adobe export issue to JIRA project PWA as Story

anthoula avatar Aug 23 '22 21:08 anthoula

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/PWA-2973 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Aug 23 '22 21:08 github-jira-sync-bot