magento2
magento2 copied to clipboard
Update definition.map.xml
fix isMultipleFiles option for fileUploader component
Description (*)
isMultipleFiles option settings doesn't work for fileUploader element in the form ui_component xml. Even if you add <isMultipleFiles>true</isMultipleFiles> it is not read and it remains false as default.
Manual testing scenarios (*)
- create a field with fileUploader element in a form ui component
- add the <isMultipleFiles>true</isMultipleFiles>
- visit the page and you could add multiple files
Contribution checklist (*)
- [X] Pull request has a meaningful description of its purpose
- [X] All commits are accompanied by meaningful commit messages
- [ ] All new or changed code is covered with unit/integration tests (if applicable)
- [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- [ ] All automated tests passed successfully (all builds are green)
Hi @LucScu. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment. :exclamation: Automated tests can be triggered manually with an appropriate comment:
@magento run all tests- run or re-run all required tests against the PR changes@magento run <test-build(s)>- run or re-run specific test build(s) For example:@magento run Unit Tests
<test-build(s)> is a comma-separated list of build names.
Allowed build names are:
Database CompareFunctional Tests CEFunctional Tests EEFunctional Tests B2BIntegration TestsMagento Health IndexSample Data Tests CESample Data Tests EESample Data Tests B2BStatic TestsUnit TestsWebAPI TestsSemantic Version Checker
You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.
For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.
@magento run all tests
@magento run all tests
@ihor-sviziev could you approve this pr?