magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Update definition.map.xml

Open LucScu opened this issue 5 months ago • 4 comments

fix isMultipleFiles option for fileUploader component

Description (*)

isMultipleFiles option settings doesn't work for fileUploader element in the form ui_component xml. Even if you add <isMultipleFiles>true</isMultipleFiles> it is not read and it remains false as default.

Manual testing scenarios (*)

  1. create a field with fileUploader element in a form ui component
  2. add the <isMultipleFiles>true</isMultipleFiles>
  3. visit the page and you could add multiple files

Contribution checklist (*)

  • [X] Pull request has a meaningful description of its purpose
  • [X] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

LucScu avatar Jun 10 '25 12:06 LucScu

Hi @LucScu. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment. :exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Jun 10 '25 12:06 m2-assistant[bot]

@magento run all tests

LucScu avatar Jun 11 '25 14:06 LucScu

@magento run all tests

LucScu avatar Jun 11 '25 15:06 LucScu

@ihor-sviziev could you approve this pr?

LucScu avatar Jun 12 '25 08:06 LucScu