magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

[Issue] Remove legacy compatibility code for PHP versions < 8.1

Open m2-assistant[bot] opened this issue 6 months ago • 3 comments

This issue is automatically created based on existing pull request: magento/magento2#39882: Remove legacy compatibility code for PHP versions < 8.1


Description (*)

This pull request removes code that was designed to be ran on PHP <8.1. Also, removed checks for PHP_VERSION_ID contact availability, since it's available in all PHP versions

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

m2-assistant[bot] avatar May 06 '25 11:05 m2-assistant[bot]

@ihor-sviziev Thank you for the report & collaboration!

Looking at the PR changes we can confirm that for PHP version < 8.0.0 legacy code can be removed. PHP_VERSION_ID is available in all the PHP versions hence we can safely remove the checks for it. Also, T_NAME_QUALIFIED & T_NAME_FULLY_QUALIFIED are available in versions starting from 8.0.0.

Hence confirming the issue.

engcom-Dash avatar Jun 18 '25 13:06 engcom-Dash

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-14971 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Jun 18 '25 14:06 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Jun 18 '25 14:06 m2-assistant[bot]