Improve Bundle Option & Selection Data Extensibility

[pykettk]

Description (*)

Updated the visibility from private to public for the following functions in Magento\Bundle\Block\Catalog\Product\View\Type\Bundle for improved extensibiility:

• getOptionItemData()
• getSelectionItemData()

Manual testing scenarios (*)

1. Create a new local module
2. Create a before/after/around plugin for each of the aforementioned functions
3. Configure the plugin in etc/di.xml
4. Enable the module
5. Enable and configure Xdebug and add breakpoints in your plugin(s)
6. Load a bundle product page on the frontend
7. Ensure the plugin(s) breakpoint(s) are hit

Questions or comments

I don't know why these were originally declared private functions so if there's a reason this change cannot be made, please let me know.

Contribution checklist (*)

• [x] Pull request has a meaningful description of its purpose
• [x] All commits are accompanied by meaningful commit messages
• [x] All new or changed code is covered with unit/integration tests (if applicable)
• [x] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [x] All automated tests passed successfully (all builds are green)

Resolved issues:

1. [x] resolves magento/magento2#34805: Improve Bundle Option & Selection Data Extensibility

[m2-assistant[bot]]

Hi @pykettk. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment. :exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

[pykettk]

Replaces outdated #34803 - see previous "QA Passed" comment here.

cc @engcom-Dash

[pykettk]

@magento run all tests

[engcom-Dash]

Hello @pykettk,

Thanks for you contributions!

As per this comment, moving it to on hold for now.

[engcom-Charlie]

Hi @pykettk,

Thank you for your contribution and patience.

As per Product Owner, currently we can not go ahead with this PR as its risky to expose these private methods, make it public. Hence closing this PR now.

Thank you!