magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

[Issue] Fix import iframe visibility

Open m2-assistant[bot] opened this issue 1 year ago • 4 comments

This issue is automatically created based on existing pull request: magento/magento2#39265: Fix import iframe visibility


Description

An iframe is displayed at the bottom of the import page during validation and subsequent data import

The display attribute with the value none is added to the iframe, previously it was style="display:none", but during refactoring this was incorrectly changed.

Related Commit

https://github.com/magento/magento2/commit/1edf22403419c04d09ccff1c587ad2479b524d37#diff-3160ffecaaf7ab21ba68a3b535d34ab5719602af66952aabe8a821cfac42da9aR172

Manual testing scenarios (*)

  1. Go to the import page in the admin panel
  2. Select any type of entity
  3. Upload the file for import
  4. Click "Check data"
  5. Click "Import"
  6. Scroll window to the bottom

image

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

m2-assistant[bot] avatar Oct 16 '24 12:10 m2-assistant[bot]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Oct 16 '24 12:10 m2-assistant[bot]

Hi @DmitryFurs,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Manual testing scenarios

  • Go to the import page in the admin panel
  • Select any type of entity
  • Upload the file for import
  • Click "Check data"
  • Click "Import"
  • Scroll window to the bottom
Screenshot 2024-10-17 at 09 51 49

The display attribute with the value none is added to the iframe.

Hence Confirming the issue.

Thanks.

engcom-Bravo avatar Oct 17 '24 04:10 engcom-Bravo

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-13250 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Oct 17 '24 04:10 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Oct 17 '24 04:10 m2-assistant[bot]