magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Rework session destroy into session clean

Open sfritzsche opened this issue 1 year ago • 2 comments

Description (*)

Before:

The current session (incl. cart items) making a password “forget” request is destroyed as soon as a password request with a formally correct email address is received.

After:

The process is only triggered if the email address really exists. If it does, only the customer session associated with the email address is reset and not the session that “requested” it.

Fixed Issues

  1. Fixes magento/magento2#39021

Manual testing scenarios (*)

  1. add a product to the shopping cart.
  2. start the "Forgot password" process on the "/customer/account/forgotpassword" page with a formally correct email address.
  3. the product is still in the shopping cart.

sfritzsche avatar Aug 28 '24 14:08 sfritzsche

Hi @sfritzsche. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Aug 28 '24 14:08 m2-assistant[bot]

@magento run all tests

sfritzsche avatar Aug 28 '24 14:08 sfritzsche