magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

[Issue] Fix overrides.xml

Open m2-assistant[bot] opened this issue 1 year ago • 2 comments
trafficstars

This issue is automatically created based on existing pull request: magento/magento2#37371: Fix overrides.xml


Without this fix it is impossible to use overrides.xml which declaratively changes the configuration of Magento tests

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. create any Magento module with web-api tests and an overrides.xml file (to suppress the ever-failing Magento tests)
  2. run all API tests and make sure that overrides.xml was ignored by the test framework

Questions or comments

Contribution checklist (*)

  • [x] Pull request has a meaningful description of its purpose
  • [x] All commits are accompanied by meaningful commit messages
  • [x] All new or changed code is covered with unit/integration tests (if applicable)
  • [x] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

m2-assistant[bot] avatar Aug 22 '24 09:08 m2-assistant[bot]

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Aug 23 '24 10:08 m2-assistant[bot]

Hello @duhon,

Thank you for the report and collaboration!

Please elaborate the description of the issue and add the steps to reproduce.

engcom-November avatar Aug 23 '24 10:08 engcom-November

description of the issue

  • Without this fix it is impossible to use overrides.xml which declaratively changes the configuration of Magento tests

steps to reproduce

  • create any Magento module with web-api tests and an overrides.xml file (to suppress the ever-failing Magento tests)
  • run all API tests and make sure that overrides.xml was ignored by the test framework

duhon avatar Sep 05 '24 19:09 duhon

Hello @duhon,

Thanks for the report and collaboration!

We have tried to reproduce the issue on the latest 2.4-develop branch and we are not able to reproduce the issue. Please find below steps

  1. Create a custom module with the REST Webapi Tests which are failing. Also added overrides.xml
Image
  1. To ignore overrides.xml from the test framework added it into phpunit_rest.xml
Image
  1. In overrides.xml we tried to skip the webapi tests which are failing.
Image
  1. Run all API Tests
Image

Image

The tests was skipped mentioned in the overrides.xml on 2.4-develop branch.

Note: Also, We verified "Magento\TestModuleOverrideConfig\Skip\SkipMethodTest" test mentioned in "dev/tests/api-functional/_files/Magento/TestModuleOverrideConfig2/Test/Api/_files/overrides.xml" This test found as failure and not skipped. But its failing on both 2.4-develop and PR (patch-1) branch.

Could you please let us know if we are missing any points here.

Thank You!

engcom-Dash avatar Apr 23 '25 08:04 engcom-Dash

Hi @duhon,

As per this comment https://github.com/magento/magento2/pull/37371#issuecomment-2892881667 we are closing this issue.

Thanks.

engcom-Bravo avatar May 20 '25 05:05 engcom-Bravo