magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

[Issue] Fix split button in order view page

Open m2-assistant[bot] opened this issue 1 year ago • 8 comments

This issue is automatically created based on existing pull request: magento/magento2#39078: Fix split button in order view page


Description (*)

This PR adds a fix for split buttons used in layout admin-2columns-left.xml The bug was added by 6ed18327 so this is a rollback of changes. Admin Panel is not for mobile so no need to add any changes to fix issues on mobile/tablet. Here is the video of the issue:

https://github.com/user-attachments/assets/84420833-ac5e-4172-93fe-173fa445bd8a

Related Pull Requests

None

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

  1. Create a custom split button on order view page.
  2. Go to Frontend and place an order
  3. Go to Admin Panel -> Sales -> Orders
  4. Go to the order view page.

Questions or comments

None

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

m2-assistant[bot] avatar Aug 21 '24 12:08 m2-assistant[bot]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Aug 21 '24 12:08 m2-assistant[bot]

@magento give me 2.4-develop instance

engcom-Bravo avatar Aug 26 '24 06:08 engcom-Bravo

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

Hi @engcom-Bravo, here is your Magento Instance: https://aebc50e540833668ecef5207acf0ed57.instances-prod.magento-community.engineering Admin access: https://aebc50e540833668ecef5207acf0ed57.instances-prod.magento-community.engineering/admin_dc79 Login: 97c61729 Password: 35c6918e8d15

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Aug 27 '24 07:08 m2-assistant[bot]

Hello @SerhiiMandrykin,

Thank you for the report and collaboration!

Verified this issue on 2.4-develop. Added a split button on order view page, and the header is scrollable. Please take a look at the screencast below:

https://github.com/user-attachments/assets/743c5070-ffd3-454f-b9db-47f945e2a36f

Hence confirming this issue.

engcom-November avatar Aug 27 '24 08:08 engcom-November

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12841 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Aug 27 '24 09:08 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Aug 27 '24 09:08 m2-assistant[bot]

Hi @SerhiiMandrykin,

As per this comment https://github.com/magento/magento2/pull/39078#issuecomment-2500256668 issue is no more reproducible hence we are closing this issue.

Thanks.

engcom-Bravo avatar Nov 29 '24 07:11 engcom-Bravo