magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

[Issue] Fix recipient and shipper address lines in fedex request

Open m2-assistant[bot] opened this issue 1 year ago • 3 comments

This issue is automatically created based on existing pull request: magento/magento2#39043: Fix recipient and shipper address lines in fedex request


Description (*)

This PR adds fixes to the FedEx shipment request. According to FedEx Ship API: https://developer.fedex.com/api/en-us/catalog/ship/v1/docs.html#operation/Create%20Shipment the addresses accept street lines as an array. Passing it as an array of a single combined string may lead to an error from FedEx API because according to the documentation, Max Length is 35 of a string.

Related Pull Requests

None

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

  1. Place an order with a FedEx shipping method
  2. Go to Admin Panel and find the order
  3. Ship the order and create a FedEx label

Questions or comments

None

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

m2-assistant[bot] avatar Aug 20 '24 11:08 m2-assistant[bot]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Aug 20 '24 11:08 m2-assistant[bot]

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Aug 26 '24 05:08 m2-assistant[bot]

Hi @SerhiiMandrykin

Thanks for your reporting and collaboration. We have verified the issue in latest 2.4-develop instance and it is working as per the documentation. Kindly refer the screenshots.

Steps to reproduce

  1. Place an order with less than 35 characters as shipping address and fedex shipping method.
  2. Create shipping label.
  3. Observe user should be able to create shipping label image
  4. Place another order with more than 35 characters as shipping address and fedex shipping method.
  5. Create shipping label.
  6. Observe user is unable to create shipping label and user receives error as shipping address is more than 35 characters. image

Please let us know if any other steps are needed to be performed.

Thanks.

engcom-Delta avatar Aug 26 '24 12:08 engcom-Delta

Hello, Any news on this please? I am experiencing the STREETLINES.TOO.LONG issue with an adress exceeding 35 characters but with 2 different lines sent as a string to FedEx api instead of an array.

ShapesGraphicStudio avatar Sep 25 '24 10:09 ShapesGraphicStudio

@engcom-Delta the API request are being sent to FedEx as [streetLine1 . streetLine2], but it should be [streetLine1, streetLine2]

SerhiiMandrykin avatar Sep 25 '24 10:09 SerhiiMandrykin