magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Cart items with custom options always out of stock in PWA (GraphQl)

Open HalievDmitry opened this issue 1 year ago • 2 comments

Preconditions and environment

  • Magento version 2.4.7-p2
  • GraphQl

Steps to reproduce

  1. create a new product with required custom option (any type) with 100 qty in stock.
  2. add this product with the selected custom option to the cart (just 1 item)
  3. go to cart page

Expected result

Cart item is in stock, you can adjust the qty and proceed to checkout.

Actual result

Cart item is out of stock and you need to remove it from your cart.

Additional information

In vendor/magento/module-inventory-graph-ql/Model/Resolver/StockStatusProvider.php:58 the $product->getSku() result passed to AreProductsSalableInterface. But the getSku() returns a combined cart item SKU (product sku + custom option sku, ex. product1-customoption1) instead of raw product SKU (ex. product1). Obviously we don't have a stock records for such combined SKUs. Looks like $product->getData('sku') might be used here. As a temporary fix I put a before plugin on AreProductsSalableInterface to "clear" the SKUs and avoid the similar bugs.

Release note

No response

Triage and priority

  • [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • [X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

HalievDmitry avatar Aug 19 '24 21:08 HalievDmitry

Hi @HalievDmitry. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] avatar Aug 19 '24 21:08 m2-assistant[bot]

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Aug 20 '24 03:08 m2-assistant[bot]

Hi @HalievDmitry ,

Thanks for your reporting and collaboration. We have verified the issue in latest 2.4-develop instance and issue is not reproducible . Kindly refer the screenshots.

Steps to Reproduce :

  1. Install latest 2.4-develop instance.
  2. create a new product with required custom option (any type) with 100 qty in stock.
  3. add this product with the selected custom option to the cart (just 1 item) image
  4. go to cart page image
  5. Update the Qty - image image Observe user is able to update the Qty Please let us know if any other steps are needed to be performed.

Thanks.

engcom-Delta avatar Sep 02 '24 11:09 engcom-Delta

Hi @HalievDmitry ,

We have noticed that this issue has not been updated since long time. Hence we assume that this issue is fixed now, so we are closing it. Please feel to raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks.

engcom-Delta avatar Sep 30 '24 08:09 engcom-Delta