magento2
magento2 copied to clipboard
ISSUE-39008 makes one ajax request per category expand click
Just a possible quick solution for:
- Fixes https://github.com/magento/magento2/issues/39008
- Fixes https://github.com/magento/magento2/issues/38851
Related:
- https://github.com/magento/magento2/pull/39016
- https://github.com/magento/magento2/pull/39007
Hi @sheepfy. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:
@magento give me test instance- deploy test instance based on PR changes@magento give me 2.4-develop instance- deploy vanilla Magento instance
:exclamation: Automated tests can be triggered manually with an appropriate comment:
@magento run all tests- run or re-run all required tests against the PR changes@magento run <test-build(s)>- run or re-run specific test build(s) For example:@magento run Unit Tests
<test-build(s)> is a comma-separated list of build names.
Allowed build names are:
Database CompareFunctional Tests CEFunctional Tests EEFunctional Tests B2BIntegration TestsMagento Health IndexSample Data Tests CESample Data Tests EESample Data Tests B2BStatic TestsUnit TestsWebAPI TestsSemantic Version Checker
You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.
For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.
@hostep I excluded the foreach in this PR.
@magento give me 2.4-develop instance
Hi @amine-y. Thank you for your request. I'm working on Magento instance for you.
Hi @amine-y, here is your Magento Instance: https://85601c298ef86979f968d28d069fb1f9.instances-prod.magento-community.engineering Admin access: https://85601c298ef86979f968d28d069fb1f9.instances-prod.magento-community.engineering/admin_6482 Login: d7530f5c Password: 95348c719415
Hello,
Internal team has started to work on it
Thanks
@sheepfy, if I got right, this Pull Request should replace https://github.com/magento/magento2/pull/39016, so the previous one can be closed. Could you confirm that?
@sheepfy, if I got right, this Pull Request should replace #39016, so the previous one can be closed. Could you confirm that?
Yes. This PR https://github.com/magento/magento2/pull/39007/files is the actual fix. The missing foreach for widgets, to be the same as in category admin page.
This PR however, updates the logic to avoid using the foreach in order to have only 1 network request per category tree expand click
@magento run all tests
Hi @sheepfy,
Thanks for your Contribution!!.
As internal team is started working on this PR. We are moving this PR On Hold till the further updates.
Thanks.
Looks like it got fixed in different way, more details here: https://github.com/magento/magento2/issues/38851#issuecomment-2345340785
I think we can close this pull request
Since it's already fixed, I'm closing this Pull Request. @sheepfy thank you so much for collaboration and contribution!