Fix Warning: Undefined array key "filters"

[thomas-kl1]

Description (*)

Fresh Install, when a new user does not have played with bookmarks yet, this silenced error is logged.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• [ ] Pull request has a meaningful description of its purpose
• [ ] All commits are accompanied by meaningful commit messages
• [ ] All new or changed code is covered with unit/integration tests (if applicable)
• [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

1. [x] resolves magento/magento2#39013: Fix Warning: Undefined array key "filters"

[m2-assistant[bot]]

Hi @thomas-kl1. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

[thomas-kl1]

@magento run all tests

[engcom-Hotel]

@magento create issue

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run Static Tests

[engcom-Hotel]

@magento run all tests

[engcom-Charlie]

It seems that review changes has been covered so moved it back to review

[engcom-Bravo]

@magento run all tests

[engcom-Bravo]

Hi @thomas-kl1,

Thanks for the collaboration & contribution!

:heavy_check_mark: QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

A lot of "Fix Warning: Undefined array key "filters" errors pop in the logs when using the Admin views (ui grids).

Before: :heavy_multiplication_x: 

main.CRITICAL: Exception: Warning: Undefined array key "filters" in /usr/local/var/www/magentok/magento2/app/code/Magento/Ui/Controller/Adminhtml/Bookmark/Save.php on line 250 in /usr/local/var/www/magentok/magento2/lib/internal/Magento/Framework/App/ErrorHandler.php:62

After: :heavy_check_mark:

There will be No Error in the Logs.

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Unit Tests

[engcom-Charlie]

@magento run Functional Tests EE

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run Semantic Version Checker, Functional Tests B2B, Functional Tests CE

[engcom-Charlie]

Functional B2B and CE failures in recent 2 builds are not consistent. They are not related to PR or not failing because of PR changes, seems to be flaky. Hence moving this PR to Merge in Progress.

Functional B2B: Run1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38996/43f32231cb1a5e50d3ad4a58a1e1e303/Functional/allure-report-b2b/index.html#categories

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38996/a464976bc37b6cb5b82b31a51a9949bf/Functional/allure-report-b2b/index.html#categories

Functional CE: Run1:

https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38996/88db4508464058e6323f57d14f892641/Functional/allure-report-ce/index.html#categories

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38996/c5ea7735164fde9706863e259a29c0fa/Functional/allure-report-ce/index.html#categories

[thomas-kl1]

Hello @engcom-Charlie , any idea if there's a chance this PR pass with next release?

[engcom-Charlie]

Hello @engcom-Charlie , any idea if there's a chance this PR pass with next release?

Hi @thomas-kl1,

We are trying to get it merge soon. We will notify you here once it will get merge.

[Calvin495]

@engcom-Charlie This fix is not in Magento 2.4.7-p1. Is there an official patch available for this fix?

[thomas-kl1]

Hello @Calvin495 you can use the diff and apply it as a patch.

[Calvin495]

@thomas-kl1

Thanks. That was the last resort :)

Is this fix included in 2.4.7-p2?

[thomas-kl1]

This fix has been merged on November 1st, the 2.4.7-p2 has been released on August 9th. 😄

For now the fix is only in the develop branch and is not part of any release yet.

[Calvin495]

@thomas-kl1

Thanks