magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Fix issue when compiling statics with multiple jobs

Open mrodespin opened this issue 1 year ago • 8 comments

Patch to fix open Magento issue https://github.com/magento/magento2/issues/38799

  • Fixes https://github.com/magento/magento2/issues/38799

mrodespin avatar Jun 19 '24 08:06 mrodespin

Hi @mrodespin. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Jun 19 '24 08:06 m2-assistant[bot]

Can confirm that this fixes my issues.

jellesiderius avatar Jul 09 '24 12:07 jellesiderius

@magento run all tests

monteshot avatar Jul 12 '24 11:07 monteshot

@magento run all tests

engcom-Bravo avatar Aug 22 '24 06:08 engcom-Bravo

Hi @mrodespin,

Thanks for the collaboration & contribution!

:heavy_check_mark: QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Go to env.php
  • Set the port information to the host in the db connection. e.g. db['connection']['default']['host'] = 'localhost:3306'
  • Execute ./magento.sh setup:static-content:deploy

Before: :heavy_multiplication_x: 

Screenshot 2024-08-22 at 12 23 47

After: :heavy_check_mark:

Screenshot 2024-08-22 at 13 32 33

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

engcom-Bravo avatar Aug 22 '24 09:08 engcom-Bravo

@magento run all tests

engcom-Charlie avatar Aug 25 '24 11:08 engcom-Charlie

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

engcom-Charlie avatar Aug 26 '24 06:08 engcom-Charlie

The Functional B2B and EE failures in recent 2 builds are known issues and not related to the PR changes hence moving this PR to Merge In Progress.

Functional B2B Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38842/1848ea78770547fa01e0c248208b0494/Functional/allure-report-b2b/index.html#categories/e89a2ef77b192fa659586970627a6e4a/3fee4ef775faff28/

image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38842/fb6fb189ab0db3ae415a94d68f159b02/Functional/allure-report-b2b/index.html#categories/e89a2ef77b192fa659586970627a6e4a/f6d6cdc83faabb49/

image

Functional EE Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38842/193e47cecbabff724bf8865e273822b9/Functional/allure-report-ee/index.html#categories

image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38842/0923be2ff0cf4098bebd1a906fdf7cf7/Functional/allure-report-ee/index.html#categories/5c3e33efaf655a884aa27c9147cb6ca1/17474efe84ca217c/

image

Known issues : EE: StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest: #ACQE-6331 B2B: AdminCreateDraftQuoteFromQuoteGridPageTest: #ACQE-6309

engcom-Charlie avatar Aug 26 '24 09:08 engcom-Charlie