magento2
magento2 copied to clipboard
Fix issue when compiling statics with multiple jobs
Patch to fix open Magento issue https://github.com/magento/magento2/issues/38799
- Fixes https://github.com/magento/magento2/issues/38799
Hi @mrodespin. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:
@magento give me test instance- deploy test instance based on PR changes@magento give me 2.4-develop instance- deploy vanilla Magento instance
:exclamation: Automated tests can be triggered manually with an appropriate comment:
@magento run all tests- run or re-run all required tests against the PR changes@magento run <test-build(s)>- run or re-run specific test build(s) For example:@magento run Unit Tests
<test-build(s)> is a comma-separated list of build names.
Allowed build names are:
Database CompareFunctional Tests CEFunctional Tests EEFunctional Tests B2BIntegration TestsMagento Health IndexSample Data Tests CESample Data Tests EESample Data Tests B2BStatic TestsUnit TestsWebAPI TestsSemantic Version Checker
You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.
For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.
Can confirm that this fixes my issues.
@magento run all tests
@magento run all tests
Hi @mrodespin,
Thanks for the collaboration & contribution!
:heavy_check_mark: QA Passed
Preconditions:
- Install fresh Magento
2.4-develop
Steps to reproduce
- Go to env.php
- Set the port information to the host in the db connection. e.g. db['connection']['default']['host'] = 'localhost:3306'
- Execute ./magento.sh setup:static-content:deploy
Before: :heavy_multiplication_x:
After: :heavy_check_mark:
Builds are failed. Hence, moving this PR to Extended Testing.
Thanks
@magento run all tests
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE
The Functional B2B and EE failures in recent 2 builds are known issues and not related to the PR changes hence moving this PR to Merge In Progress.
Functional B2B
Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38842/1848ea78770547fa01e0c248208b0494/Functional/allure-report-b2b/index.html#categories/e89a2ef77b192fa659586970627a6e4a/3fee4ef775faff28/
Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38842/fb6fb189ab0db3ae415a94d68f159b02/Functional/allure-report-b2b/index.html#categories/e89a2ef77b192fa659586970627a6e4a/f6d6cdc83faabb49/
Functional EE Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38842/193e47cecbabff724bf8865e273822b9/Functional/allure-report-ee/index.html#categories
Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38842/0923be2ff0cf4098bebd1a906fdf7cf7/Functional/allure-report-ee/index.html#categories/5c3e33efaf655a884aa27c9147cb6ca1/17474efe84ca217c/
Known issues : EE: StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest: #ACQE-6331 B2B: AdminCreateDraftQuoteFromQuoteGridPageTest: #ACQE-6309