magento2
magento2 copied to clipboard
dev:di:info error
Description (*)
$paramsTable->render() not return anything (https://github.com/symfony/console/blob/v6.4.2/Helper/Table.php#L318). It call $this->output->writeln for display table => not need $output->writeln in magento
Related Pull Requests
Fixed Issues (if relevant)
- Fixes magento/magento2#38740
Manual testing scenarios (*)
- ...
- ...
Questions or comments
Contribution checklist (*)
- [ ] Pull request has a meaningful description of its purpose
- [ ] All commits are accompanied by meaningful commit messages
- [ ] All new or changed code is covered with unit/integration tests (if applicable)
- [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- [ ] All automated tests passed successfully (all builds are green)
Hi @rogerdz. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:
@magento give me test instance- deploy test instance based on PR changes@magento give me 2.4-develop instance- deploy vanilla Magento instance
:exclamation: Automated tests can be triggered manually with an appropriate comment:
@magento run all tests- run or re-run all required tests against the PR changes@magento run <test-build(s)>- run or re-run specific test build(s) For example:@magento run Unit Tests
<test-build(s)> is a comma-separated list of build names.
Allowed build names are:
Database CompareFunctional Tests CEFunctional Tests EEFunctional Tests B2BIntegration TestsMagento Health IndexSample Data Tests CESample Data Tests EESample Data Tests B2BStatic TestsUnit TestsWebAPI TestsSemantic Version Checker
You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.
For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.
@magento run all tests
@magento run WebAPI Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B
@magento run WebAPI Tests, Functional Tests EE, Functional Tests B2B
Hello,
Internal team has started to work on it
Thanks.
For some reason, this PR wasn't marked as merged, even though the code was merged (cherry-picked?) recently here: https://github.com/magento/magento2/commit/c6d91bdf2468a104ffef556cb51031959bf245ff
@hostep Thanks for your contribution!!.
Hello,
As I can see this issue got fixed in the scope of the internal Jira ticket AC-11999 by the internal team Related commits:https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-11999&type=commits
Based on the Jira ticket, the target version is 2.4.8-beta1.
Thanks