magento2
magento2 copied to clipboard
[Issue] The loader blocks the shipping methods after the postcode is changed, shipping rates validation rules
This issue is automatically created based on existing pull request: magento/magento2#38726: The loader blocks the shipping methods after the postcode is changed, shipping rates validation rules
Description (*)
In instance where we have custom shipping methods without shipping rates validation rules, the loader blocks the shipping methods after the postcode is changed in the shipping address during checkout and does not disappear.
File: vendor/magento/module-checkout/view/frontend/web/js/model/shipping-rates-validator.js
Contribution checklist (*)
- [ ] Pull request has a meaningful description of its purpose
- [ ] All commits are accompanied by meaningful commit messages
- [ ] All new or changed code is covered with unit/integration tests (if applicable)
- [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- [ ] All automated tests passed successfully (all builds are green)
Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
-
- Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
-
- Verify that issue has a meaningful description and provides enough information to reproduce the issue.
-
- Add
Area: XXXXXlabel to the ticket, indicating the functional areas it may be related to.
- Add
-
- Verify that the issue is reproducible on
2.4-developbranchDetails
- Add the comment@magento give me 2.4-develop instanceto deploy test instance on Magento infrastructure.
- If the issue is reproducible on2.4-developbranch, please, add the labelReproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
- Verify that the issue is reproducible on
- Join Magento Community Engineering Slack and ask your questions in #github channel.
Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
- [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
- [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
- [ ] 3. Add
Area: XXXXXlabel to the ticket, indicating the functional areas it may be related to. - [ ] 4. Verify that the issue is reproducible on
2.4-developbranchDetails
- Add the comment@magento give me 2.4-develop instanceto deploy test instance on Magento infrastructure.
- If the issue is reproducible on2.4-developbranch, please, add the labelReproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here! - [ ] 5. Add label
Issue: Confirmedonce verification is complete. - [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.
Hello @mattkrupnik,
Thank you for the report and collaboration!
Verified this issue on 2.4-develop. With a custom shipping method without validation rules, if the postal code is changed in the shipping address form, the shipping methods will keep loading, blocking the user to select a shipping method.
Note: This only happens when the custom shipping methods are enabled without validation rules, if another shipping method with validation is enabled this issue does not occour.
Take a look at the screenshot below:
Please find the attached custom shipping module used to reproduce this issue. ShipVendor.zip
Hence confirming this issue.
Thank you.
:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11993 is successfully created for this GitHub issue.
:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
Hello,
Internal team has started to work on it.
Thanks.
Hello,
As I can see this issue got fixed in the scope of the internal Jira ticket AC-11993 by the internal team Related commits:https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-11993&type=commits
Based on the Jira ticket, the target version is 2.4.8-beta1.
Thanks