magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

[Issue] Avoid re-rendering already loaded grid for Product Options (SwiftOtter's SOP-348)

Open m2-assistant[bot] opened this issue 1 year ago • 6 comments
trafficstars

This issue is automatically created based on existing pull request: magento/magento2#38734: Avoid re-rendering already loaded grid for Product Options (SwiftOtter's SOP-348)


Description (*)

In the Product Edit Page, when you open the “Customizable Options” bar, all the Product Options are visible. Suddenly, the loader icon pops up and all the options are rendered again.

The bug was introduced in 2022, and is affecting Product Edit page especiall with a big subsets of options.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. When I open “Customizable Options” section on Edit Product page, and the values of the options are rendered, the loader doesn’t appear afterwards, and the content is not re-rendered.
  2. ...

Questions or comments

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

m2-assistant[bot] avatar May 21 '24 11:05 m2-assistant[bot]

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar May 21 '24 11:05 m2-assistant[bot]

Hi @lbajsarowicz ,

Thanks for reporting and collaboration.

Verified the issue in 2.4-develop instance and the issue is not reproducible.

Steps to reproduce:-

1.Go to In the Product Edit Page, 2.Open the “Customizable Options” bar and verify

Please refer the attached video and let us if we are missing something.

All the Product Options are visible. the loader icon doesn't pop up and all the options are not rendered .

https://github.com/magento/magento2/assets/51681379/20b57529-5a10-4760-8382-a4e6e50a4bb9

engcom-Delta avatar May 22 '24 10:05 engcom-Delta

@magento give me 2.4-develop instance

lbajsarowicz avatar May 22 '24 11:05 lbajsarowicz

Hi @lbajsarowicz. Thank you for your request. I'm working on Magento instance for you.

Hi @lbajsarowicz, here is your Magento Instance: https://24847c135798697fec3c683b59c9ce6c.instances-prod.magento-community.engineering Admin access: https://24847c135798697fec3c683b59c9ce6c.instances-prod.magento-community.engineering/admin_3910 Login: 0a674ee7 Password: 200f3f5e1193

I added 3 options, with 22 variants each. The problem is hard to spot (loading quickly) but still occurs. I'll try to provide you with MFTF ( 🙃 ) test scenario for that after my holiday.

lbajsarowicz avatar May 22 '24 11:05 lbajsarowicz

Hi @lbajsarowicz ,

Thanks for reporting and collaboration.

Awaiting your reply on this issue to move further.

Thanks,

engcom-Delta avatar Jun 03 '24 12:06 engcom-Delta

Hi @lbajsarowicz ,

Could you please provide more information on this issue as mentioned above.

Thank you,

engcom-Delta avatar Jun 17 '24 10:06 engcom-Delta

Hi @lbajsarowicz ,

We have verified this again on 2.4-develop and we are not able to reproduce this issue.

Hence we are closing this.Feel free to raise a new issue or reopen this if you need more assistance.

Please refer the attached video.

https://github.com/magento/magento2/assets/51681379/c94da5fb-5976-42b2-9e5b-7bad3471a64a

Thanks,

engcom-Delta avatar Jun 27 '24 14:06 engcom-Delta