magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

The loader blocks the shipping methods after the postcode is changed, shipping rates validation rules

Open mattkrupnik opened this issue 1 year ago • 4 comments
trafficstars

Description (*)

In instance where we have custom shipping methods without shipping rates validation rules, the loader blocks the shipping methods after the postcode is changed in the shipping address during checkout and does not disappear.

File: vendor/magento/module-checkout/view/frontend/web/js/model/shipping-rates-validator.js

image

image

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

  1. [x] resolves magento/magento2#38742: The loader blocks the shipping methods after the postcode is changed, shipping rates validation rules

mattkrupnik avatar May 15 '24 07:05 mattkrupnik

Hi @mattkrupnik. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar May 15 '24 07:05 m2-assistant[bot]

@magento run all tests

mattkrupnik avatar May 15 '24 07:05 mattkrupnik

@magento run all tests

mattkrupnik avatar May 15 '24 12:05 mattkrupnik

@magento create issue

engcom-Hotel avatar May 21 '24 11:05 engcom-Hotel

Hello,

Internal team has started to work on it.

Thanks.

engcom-Bravo avatar Jun 14 '24 06:06 engcom-Bravo

For some reason, this PR wasn't marked as merged, even though the code was merged (via cherry-picking) recently as part of this bigger merge: https://github.com/magento/magento2/commit/1bafc5712abd635395f0bcfe24ea3f198c18f615

hostep avatar Jul 04 '24 19:07 hostep

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-11993 by the internal team Related commits:https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-11993&type=commits

Based on the Jira ticket, the target version is 2.4.8-beta1.

Thanks

engcom-Bravo avatar Jul 05 '24 07:07 engcom-Bravo