magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Default Product Attribute Settings Issue

Open FluidGuy opened this issue 1 year ago • 22 comments

Preconditions and environment

  • Magento version
  • Anything else that would help a developer reproduce the bug Magento version 2.4.7 When editing a product attribute if a default is selected there is no way of unselecting all, so there is always some default now for that option. Work around is whenever creating new parts manually turn off all attributes that are turned on by default

Steps to reproduce

  1. Go into admin view
  2. Select Stores in admin side panel
  3. Select product under attributes

Scenario 1:

  1. Select an attribute to edit which has Catalog Input Type for Store Owner is Visual swatch or dropdown
  2. If the "is default" option is selected, there is no way to set the attribute to no longer have a default option

Scenario 2:

  1. Select an attribute to edit which has Catalog Input Type for Store Owner is Multiple Select
  2. If you deselect the default option then save or save and continue it still is set as the default
  3. If you select multiple options as default and deselect the default options then save or save and continue all the options are selected as default

Expected result

Scenario 1: If a default is selected, there would be a way to unselect having a default set Scenario 2: If you deselect the default option then save or save and continue it should removed from default

Actual result

Scenario 1: Once a default is set, there is no way to turn defaults off for that option Scenario 2: Once a default is set, after we deselect it , its never saved

Additional information

image See how a default is set to the 1675 psi option, now this attribute will always have some default set and it cannot be changed to not be on by default

Release note

No response

Triage and priority

  • [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [X] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

FluidGuy avatar May 07 '24 15:05 FluidGuy

Hi @FluidGuy. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] avatar May 07 '24 15:05 m2-assistant[bot]

@magento give me 2.4-develop instance

FluidGuy avatar May 07 '24 15:05 FluidGuy

Hi @FluidGuy. Thank you for your request. I'm working on Magento instance for you.

Hi @FluidGuy, here is your Magento Instance: https://af3515771dceec625d611020de141a44.instances-prod.magento-community.engineering Admin access: https://af3515771dceec625d611020de141a44.instances-prod.magento-community.engineering/admin_b388 Login: 44d7ece2 Password: eb48b187f2c8

The issue occurs in the vanilla version, if you deselect the default option then save or save and continue it still is set as the default

FluidGuy avatar May 07 '24 15:05 FluidGuy

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • [ ] 5. Add label Issue: Confirmed once verification is complete.
  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar May 08 '24 03:05 m2-assistant[bot]

@magento give me 2.4-develop instance

engcom-Delta avatar May 08 '24 07:05 engcom-Delta

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

Hi @engcom-Delta, here is your Magento Instance: https://af3515771dceec625d611020de141a44.instances-prod.magento-community.engineering Admin access: https://af3515771dceec625d611020de141a44.instances-prod.magento-community.engineering/admin_81ea Login: b8c4153b Password: 3499340bf85a

@magento give me 2.4.7 instance

engcom-Delta avatar May 08 '24 10:05 engcom-Delta

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

Hi @engcom-Delta, here is your Magento Instance: https://58e234b4d013605aaa4f4296f10c060d.instances-prod.magento-community.engineering Admin access: https://58e234b4d013605aaa4f4296f10c060d.instances-prod.magento-community.engineering/admin_2fb3 Login: 0d5bc15c Password: d84969deecff

@magento give me 2.4-develop instance

engcom-Delta avatar May 09 '24 10:05 engcom-Delta

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

Hi @engcom-Delta, here is your Magento Instance: https://af3515771dceec625d611020de141a44.instances-prod.magento-community.engineering Admin access: https://af3515771dceec625d611020de141a44.instances-prod.magento-community.engineering/admin_edc9 Login: 975fcdd0 Password: b93513674884

Hi @FluidGuy ,

Verified the issue on 2.4-develop, 2.4.7 and it is reproducible.

Hence, Confirming the issue.

Steps to reproduce:-

1.Go into admin view 2.Select Stores in admin side panel 3.Select product under attributes

Scenario 1:

4.Select an attribute to edit which has Catalog Input Type for Store Owner is Visual swatch or dropdown 5.If the "is default" option is selected, there is no way to set the attribute to no longer have a default option

Scenario 2:

6.Select an attribute to edit which has Catalog Input Type for Store Owner is Multiple Select 7.If you deselect the default option then save or save and continue it still is set as the default 8.If you select multiple options as default and deselect the default options then save or save and continue all the options are selected as default

Go into admin view

Screenshot 2024-05-08 at 2 06 21 PM

Select Stores in admin side panel

Screenshot 2024-05-08 at 2 06 42 PM

Select product under attributes

Screenshot 2024-05-08 at 2 07 17 PM

Select an attribute to edit which has Catalog Input Type for Store Owner is Multiple Select

Screenshot 2024-05-09 at 6 27 46 PM

Deselected

Screenshot 2024-05-09 at 6 28 13 PM

Saved

Screenshot 2024-05-09 at 6 28 21 PM

If you deselect the default option then save or save and continue it still is set as the default

Screenshot 2024-05-09 at 6 28 30 PM

multiple option selected as default and after deselecting both , its not saved

Screenshot 2024-05-09 at 6 34 01 PM

Select an attribute to edit which has Catalog Input Type for Store Owner is Visual swatch or dropdown

Screenshot 2024-05-09 at 6 28 55 PM Screenshot 2024-05-09 at 6 41 07 PM

If the "is default" option is selected, there is no way to set the attribute to no longer have a default option, We have to select another option to deselect another

Screenshot 2024-05-09 at 6 29 05 PM

engcom-Delta avatar May 09 '24 13:05 engcom-Delta

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11932 is successfully created for this GitHub issue.

github-jira-sync-bot avatar May 09 '24 13:05 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar May 09 '24 13:05 m2-assistant[bot]

@magento I am working on this

rostilos avatar Jul 12 '24 07:07 rostilos

@magento give me 2.4-develop instance

engcom-Bravo avatar Aug 26 '24 05:08 engcom-Bravo

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

Hi @engcom-Bravo, here is your Magento Instance: https://af3515771dceec625d611020de141a44.instances-prod.magento-community.engineering Admin access: https://af3515771dceec625d611020de141a44.instances-prod.magento-community.engineering/admin_f08e Login: 332fdbfc Password: 546bb22ffc5b

Hi @FluidGuy,

Internal team has started to work on it

Thanks.

engcom-Bravo avatar Sep 16 '24 08:09 engcom-Bravo

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-11932 by the internal team Related commits:https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-11932&type=commits

Based on the Jira ticket, the target version is 2.4.8-beta2.

Thanks

engcom-Bravo avatar Dec 16 '24 04:12 engcom-Bravo