magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Published 20 hours ago • verified publisher icon magento

Update success message on admin backend with field changed ref

Open Franciscof-Serfe opened this issue 1 year ago • 9 comments

Description (*)

In relation to this issue https://github.com/magento/magento2/issues/38352, it was detected that the admin user when modifying some field of his account and recording it, the message he received was generic (You saved the account).

For this reason, through this PR we add the information of the modified field(s) to the success message.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#38352

Manual testing scenarios (*)

  1. Backend -> account setting
  2. modify 1 field and save.
  3. modify 2 fields and save.
  4. modify x fields and save.
  5. Verify that all fields can be modified

Attached video of the tests successMessage.webm

image image image

Questions or comments

FYI: Redirecting to the main dashboard was considered but since the user can decide to generate other modifications after modifying the password, that feature was rejected.

Contribution checklist (*)

  • [x] Pull request has a meaningful description of its purpose
  • [x] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

Franciscof-Serfe avatar May 04 '24 05:05 Franciscof-Serfe

Hi @Franciscof-Serfe. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar May 04 '24 05:05 m2-assistant[bot]

@magento I'm working on it

Franciscof-Serfe avatar May 04 '24 05:05 Franciscof-Serfe

Hi @Franciscof-Serfe. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] avatar May 06 '24 02:05 magento-deployment-service[bot]

Hi @Franciscof-Serfe, here is your Magento Instance: https://b3cd20f43b29fa6ce0b5fa97d193c818.instances-prod.magento-community.engineering Admin access: https://b3cd20f43b29fa6ce0b5fa97d193c818.instances-prod.magento-community.engineering/admin_bef4 Login: 96154a79 Password: fb4a6db339a8

magento-deployment-service[bot] avatar May 06 '24 02:05 magento-deployment-service[bot]

@magento give me 2.4-develop instance

Den4ik avatar May 10 '24 14:05 Den4ik

Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] avatar May 10 '24 14:05 magento-deployment-service[bot]

Hi @Den4ik, here is your Magento Instance: https://73f7df1580919d100034e255e83e3964.instances-prod.magento-community.engineering Admin access: https://73f7df1580919d100034e255e83e3964.instances-prod.magento-community.engineering/admin_445b Login: 11889ed1 Password: c496798a8e42

magento-deployment-service[bot] avatar May 10 '24 15:05 magento-deployment-service[bot]

@magento run all tests

Franciscof-Serfe avatar Aug 13 '24 15:08 Franciscof-Serfe

Hi @Franciscof-Serfe,

Thank you for your contribution!

The Magento core engineering team is working on the issue which you have addressed in this PR. Team will cherry pick the commits from your PR and may do further implementation to cover few more scenarios as needed. We will reach out to you if we need more information. For now, you can pause work on this PR.

Thank you once again!

engcom-Bravo avatar Oct 14 '24 07:10 engcom-Bravo

As mentioned here, Magento core engineering team tried to reproduce this issue and found that its not reproducible on 2.4-develop installation. It’s only reproducible on 2.4.4-p12-develop. In order to overcome this problem, we recommend you to upgrade to Magento's latest version.

For now, we are closing this PR, please feel free to reopen it for any updates.

engcom-Charlie avatar Dec 13 '24 10:12 engcom-Charlie

Hi @Franciscof-Serfe,

Thank you for your contribution! The Magento core engineering team is working on the issue which you have addressed in this PR. The message will be updated according to your suggestions, while the redirection will remain unchanged. Team will cherry pick the commits from your PR and may do further implementation to cover few more scenarios as needed. We will reach out to you if we need more information. For now, you can pause work on this PR.

Thanks.

engcom-Bravo avatar Dec 18 '24 08:12 engcom-Bravo

Hi @Franciscof-Serfe. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment. :exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Dec 18 '24 08:12 m2-assistant[bot]

Hello,

The PR's issue got fixed in the scope of the internal Jira ticket AC-10886 by the internal team Related commits: https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-10886&type=commits

Based on the Jira ticket, the target version is 2.4.8-beta2.

Thanks

engcom-Charlie avatar Dec 31 '24 07:12 engcom-Charlie