magento2
magento2 copied to clipboard
Drop page id from result
Description (*)
Given the unit test: \Magento\Cms\Test\Unit\Model\GetUtilityPageIdentifiersTest::testExecute
Expected result is a list of identifiers. Currently, if we set the following settings from BO:
- web/default/cms_home_page
- web/default/cms_no_route
- web/default/cms_no_cookies
The format saved in the config is:
Related Pull Requests
Fixed Issues (if relevant)
- Fixes magento/magento2#38666
Manual testing scenarios (*)
- 2 websites (a & b) with a specific home page configured for each (e.g: home-a for global, and home-b for website b)
- Create a sitemap for each websites
- Generate the sitemap from the admin grid
Questions or comments
Contribution checklist (*)
- [ ] Pull request has a meaningful description of its purpose
- [ ] All commits are accompanied by meaningful commit messages
- [ ] All new or changed code is covered with unit/integration tests (if applicable)
- [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- [ ] All automated tests passed successfully (all builds are green)
Hi @thomas-kl1. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:
@magento give me test instance- deploy test instance based on PR changes@magento give me 2.4-develop instance- deploy vanilla Magento instance
:exclamation: Automated tests can be triggered manually with an appropriate comment:
@magento run all tests- run or re-run all required tests against the PR changes@magento run <test-build(s)>- run or re-run specific test build(s) For example:@magento run Unit Tests
<test-build(s)> is a comma-separated list of build names.
Allowed build names are:
Database CompareFunctional Tests CEFunctional Tests EEFunctional Tests B2BIntegration TestsMagento Health IndexSample Data Tests CESample Data Tests EESample Data Tests B2BStatic TestsUnit TestsWebAPI TestsSemantic Version Checker
You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.
For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.
@magento run Unit Tests
In continuity to https://github.com/magento/magento2/commit/0ce75991942a56663a4fc77b3cc8eb6e1cdddce5
My requested changes still makes sense because the expected behavior of the service is to return a list of identifiers from the current scope.
I'm going to update the PR to align changes.
@magento run all tests