magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Drop page id from result

Open thomas-kl1 opened this issue 1 year ago • 4 comments

Description (*)

Given the unit test: \Magento\Cms\Test\Unit\Model\GetUtilityPageIdentifiersTest::testExecute

Expected result is a list of identifiers. Currently, if we set the following settings from BO:

  • web/default/cms_home_page
  • web/default/cms_no_route
  • web/default/cms_no_cookies

The format saved in the config is: |<page_id>

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#38666

Manual testing scenarios (*)

  1. 2 websites (a & b) with a specific home page configured for each (e.g: home-a for global, and home-b for website b)
  2. Create a sitemap for each websites
  3. Generate the sitemap from the admin grid

Questions or comments

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

thomas-kl1 avatar Apr 26 '24 09:04 thomas-kl1

Hi @thomas-kl1. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Apr 26 '24 09:04 m2-assistant[bot]

@magento run Unit Tests

thomas-kl1 avatar Apr 26 '24 13:04 thomas-kl1

In continuity to https://github.com/magento/magento2/commit/0ce75991942a56663a4fc77b3cc8eb6e1cdddce5

My requested changes still makes sense because the expected behavior of the service is to return a list of identifiers from the current scope.

I'm going to update the PR to align changes.

thomas-kl1 avatar Apr 30 '24 13:04 thomas-kl1

@magento run all tests

thomas-kl1 avatar May 02 '24 18:05 thomas-kl1