magento2
magento2 copied to clipboard
38662 - Graphql type error fix
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
- Fixes magento/magento2#38662
Manual testing scenarios (*)
- ...
- ...
Questions or comments
Contribution checklist (*)
- [ ] Pull request has a meaningful description of its purpose
- [ ] All commits are accompanied by meaningful commit messages
- [ ] All new or changed code is covered with unit/integration tests (if applicable)
- [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- [ ] All automated tests passed successfully (all builds are green)
Hi @Nuranto. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:
@magento give me test instance- deploy test instance based on PR changes@magento give me 2.4-develop instance- deploy vanilla Magento instance
:exclamation: Automated tests can be triggered manually with an appropriate comment:
@magento run all tests- run or re-run all required tests against the PR changes@magento run <test-build(s)>- run or re-run specific test build(s) For example:@magento run Unit Tests
<test-build(s)> is a comma-separated list of build names.
Allowed build names are:
Database CompareFunctional Tests CEFunctional Tests EEFunctional Tests B2BIntegration TestsMagento Health IndexSample Data Tests CESample Data Tests EESample Data Tests B2BStatic TestsUnit TestsWebAPI TestsSemantic Version Checker
You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.
For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.
@magento run all tests
@magento run WebAPI Tests, Static Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B
@magento run all tests
Hi @Nuranto,
Thank you for your contribution!
:heavy_check_mark: QA Passed
Preconditions:
- Install fresh Magento
2.4-develop
Steps to reproduce
- Created customer custom attribute with type as int
'custom',
[
'label' => 'custom',
'input' => 'select',
'type' => 'int',
'source' => 'Magento\Eav\Model\Entity\Attribute\Source\Boolean',
'required' => true,
'default' => '1',
'position' => 333,
'visible' => true,
'system' => false,
'is_used_in_grid' => true,
'is_visible_in_grid' => true,
'is_filterable_in_grid' => true,
'is_searchable_in_grid' => false,
'backend' => ''
]
- Set developer mode in the magento instance
- Create one customer and logged in with that user in storefront
- Execute below GraphQl query
query AccountDashboard {
__typename
customer {
email
__typename
}
}
Before: :heavy_multiplication_x:
After: :heavy_check_mark: on PR branch
Build is failing hence moving this PR to Extended Testing.
@magento run Functional Tests EE, Functional Tests B2B
The Functional B2B test failures are different in recent 2 builds hence seems to be flaky and not related to PR.
Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38663/ef6aa3f8d6ef4999b8fa98a5358ca53a/Functional/allure-report-b2b/index.html#categories
Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38663/93200a807671c97c1bae511bc29e0325/Functional/allure-report-b2b/index.html#categories
Some of the Functional EE failures are not consistent in recent 2 builds, seems to be flaky and not related to PR. One test failure is consistent and its a known failure and have open issue for the same. Hence moving this PR to Merge in Progress.
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38663/a22056aa7891bc00858d300a3a618145/Functional/allure-report-ee/index.html#categories/f5a70ec99dae2c5e7b2f1aa499dc4363/5a67b3984193b59f/
Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38663/df567d24129aa262ab672da5a413161b/Functional/allure-report-ee/index.html#categories
Known issue :
- StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest: #ACQE-6331