Ensured the Page cache identifier is read in the same way and checking and saving the cache identifier

[digitalrisedorset]

Ensured the Page cache identifier is read in the same way and checking and saving the cache identifier

The change consists using a new model that pulls the design + store cache parameters. This model is injected in both places that needs these cache information. This has meant a plugin was removed in favour of this model.

Description (*)

When the page gets loaded, the FPC checks if the page cache identifier is already saved in the cache. This reading checks the server environment variables (eg: PARAM_RUN_CODE). When the page has been rendered, the page cache identifier is saved to prevent the same page to be reloaded the next loads the same version for it. The identifier was currently saved differently to the identifier created in the reading phase and that was breaking the cache

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#38626

Manual testing scenarios (*)

Test 1: Backward compatibility - The FPC works

Setup the Magento store with no environment variable PARAM_RUN_CODE, PARAM_RUN_TYPE, ensure the Full page cache is enabled and set the developer mode active, load a page twice and verify the second load is cached by checking the header X-Magento-Cache-Debug

Test 2: Test the fault - The FPC works with environment variables

Setup the Magento store with some environment variables PARAM_RUN_CODE, PARAM_RUN_TYPE, ensure the Full page cache is enabled and set the developer mode active, load a page twice and verify the second load is cached by checking the header X-Magento-Cache-Debug

Questions or comments

Contribution checklist (*)

• [ ] Pull request has a meaningful description of its purpose
• [ ] All commits are accompanied by meaningful commit messages
• [ ] All new or changed code is covered with unit/integration tests (if applicable)
• [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [ ] All automated tests passed successfully (all builds are green)

[m2-assistant[bot]]

Hi @digitalrisedorset. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

[digitalrisedorset]

@magento run all tests

[engcom-Bravo]

Hi,

Internal team has started to work on it

Thanks.

[hostep]

For some reason, this PR wasn't marked as merged, even though (some of) the code was merged (via cherry-picks) recently as part of this bigger merge: https://github.com/magento/magento2/commit/0c53bbf7b6712c9b979a1c7ee71594ce523d78e3

[engcom-Bravo]

@hostep Thanks for your contribution!!.

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-11819 by the internal team Related commits:https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-11819&type=commits

Based on the Jira ticket, the target version is 2.4.8-beta1.

Thanks

[Bhavik-kumar]

Hi @magnto

When is it expected that this problem will be included in control release 2.4.7-p1? People have been certifying 2.4.7 for a few days now.

Is this same issue resolve for Varnish?

Bhavik