[Issue] Shipping price showing diffrent in printed pdf

[m2-assistant[bot]]

trafficstars

This issue is automatically created based on existing pull request: magento/magento2#38595: Shipping price showing diffrent in printed pdf

---

Description (*)

In Stores -> Configuration -> Sales -> Tax -> In the "Display Shipping Price" tab, we can specify whether to show shipping prices including or excluding tax. As seen in screenshot 1, I've set the "Display Shipping Price" option to "Including Tax." Consequently, in screenshot 2, the shipping price is displayed including tax on the sales-order_invoice-view page. However, when we print the order in PDF format from this page, the shipping price is shown as excluding tax, which is incorrect. It should be displayed as per tax configuration and similar to the sales-order_invoice-view page because we are printing the page. You can view the printed PDF in screenshot 3.

Screenshot-1:

Screenshot-2:

Screenshot-3:

Manual testing scenarios (*)

1: Navigate to Admin->Store->Sales->Tax and Select the option as shown in screenshot 4 &5 Screenshot-4:

Screenshot 5:

2: create a one tax rule you can see the screenshot 6 i have created one tax rule with 25% tax rate Screenshot-6:

3:Now order one product from the frontend 4:Now navigate to admin side and create a invoice of that order 5:Now, navigate to Sales -> Invoice and view the invoice you created. 6:now print the order from invoice page as you can see the diffrence of the shipping price in the sales-order_invoice-view page and in the pdf as depricated in screenshot 2 & 3.

Expected result (*)

The shipping charges should be shown the same way they are displayed on the sales-order_invoice-view page since we are printing the page.

Actual result (*)

The shipping charges are displayed differently on the PDF compared to the sales order invoice view page

Aditional information

The file public_html/app/code/Magento/Sales/Model/Order/Pdf/AbstractPdf.php is responsible for the content seen in the printed PDF. The logic for displaying shipping charges is found in lines 607 to 610 of this file. However, there is no logic implemented to show shipping charges according to the configuration settings. On the other hand, in public_html/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/create/form.phtml, the logic is implemented to fetch the configuration and then display the shipping charges accordingly on the sales-order_invoice-view page. You can see the logic of form.phtml in Screenshot 7, where shipping charges are displayed according to the configuration. However, in AbstractPdf.php, there is no such logic implemented, and only the shipping price excluding tax is shown, as depicted in Screenshot 8.

Screenshot 7:

Screenshot-8:

Contribution checklist (*)

• [ ] Pull request has a meaningful description of its purpose
• [ ] All commits are accompanied by meaningful commit messages
• [ ] All new or changed code is covered with unit/integration tests (if applicable)
• [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [ ] All automated tests passed successfully (all builds are green)

[m2-assistant[bot]]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @engcom-Bravo, here is your Magento Instance: https://b975419e9312e1fbe5f1deee35916b4b.instances-prod.magento-community.engineering Admin access: https://b975419e9312e1fbe5f1deee35916b4b.instances-prod.magento-community.engineering/admin_b042 Login: 99d73453 Password: f5d4bb9deabb

[engcom-Bravo]

Hi @Dhruvbasan,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the attached screenshots.

Manual testing scenarios

• Navigate to Admin->Store->Sales->Tax and Select the option as shown in screenshot 4 &5
• create a one tax rule you can see the screenshot 6 i have created one tax rule with 25% tax rate
• Now order one product from the frontend
• Now navigate to admin side and create a invoice of that order
• Now, navigate to Sales -> Invoice and view the invoice you created.
• now print the order from invoice page as you can see the diffrence of the shipping price in the sales-order_invoice-view page and in the pdf as depricated in screenshot 2 & 3.

The shipping charges are displayed differently on the PDF compared to the sales order invoice view page

Hence Confirming the issue.

Thanks.

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11798 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[engcom-Bravo]

Hello,

Internal team has started to work on it

Thanks.

[hostep]

Probably fixed by https://github.com/magento/magento2/commit/76362cfc120153255e7f1079d62e47eb3dcc96eb ?

[engcom-Bravo]

@hostep Thanks for your contribution!!.

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-11798 by the internal team Related commits:https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-11798&type=commits

Based on the Jira ticket, the target version is 2.4.8-beta1.

Thanks