Shipping price showing different in printed pdf

[DhruvBasan]

Description (*)

In Stores -> Configuration -> Sales -> Tax -> In the "Display Shipping Price" tab, we can specify whether to show shipping prices including or excluding tax. As seen in screenshot 1, I've set the "Display Shipping Price" option to "Including Tax." Consequently, in screenshot 2, the shipping price is displayed including tax on the sales-order_invoice-view page. However, when we print the order in PDF format from this page, the shipping price is shown as excluding tax, which is incorrect. It should be displayed as per tax configuration and similar to the sales-order_invoice-view page because we are printing the page. You can view the printed PDF in screenshot 3.

Screenshot-1:

Screenshot-2:

Screenshot-3:

Manual testing scenarios (*)

1: Navigate to Admin->Store->Sales->Tax and Select the option as shown in screenshot 4 &5 Screenshot-4:

Screenshot 5:

2: create a one tax rule you can see the screenshot 6 i have created one tax rule with 25% tax rate Screenshot-6:

3:Now order one product from the frontend 4:Now navigate to admin side and create a invoice of that order 5:Now, navigate to Sales -> Invoice and view the invoice you created. 6:now print the order from invoice page as you can see the diffrence of the shipping price in the sales-order_invoice-view page and in the pdf as depricated in screenshot 2 & 3.

Expected result (*)

The shipping charges should be shown the same way they are displayed on the sales-order_invoice-view page since we are printing the page.

Actual result (*)

The shipping charges are displayed differently on the PDF compared to the sales order invoice view page

Aditional information

The file public_html/app/code/Magento/Sales/Model/Order/Pdf/AbstractPdf.php is responsible for the content seen in the printed PDF. The logic for displaying shipping charges is found in lines 607 to 610 of this file. However, there is no logic implemented to show shipping charges according to the configuration settings. On the other hand, in public_html/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/create/form.phtml, the logic is implemented to fetch the configuration and then display the shipping charges accordingly on the sales-order_invoice-view page. You can see the logic of form.phtml in Screenshot 7, where shipping charges are displayed according to the configuration. However, in AbstractPdf.php, there is no such logic implemented, and only the shipping price excluding tax is shown, as depicted in Screenshot 8.

Screenshot 7:

Screenshot-8:

Contribution checklist (*)

• [ ] Pull request has a meaningful description of its purpose
• [ ] All commits are accompanied by meaningful commit messages
• [ ] All new or changed code is covered with unit/integration tests (if applicable)
• [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

1. [x] resolves magento/magento2#38608: Shipping price showing diffrent in printed pdf

[m2-assistant[bot]]

Hi @DhruvBasan. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

[DhruvBasan]

@magento run all tests

[engcom-Hotel]

@magento create issue

[engcom-Hotel]

@magento run all tests

[engcom-Charlie]

Hi @DhruvBasan,

Thank you for your contribution!

Did you get time to work on the changes.

Thank you!

[DhruvBasan]

@engcom-Hotel @engcom-Charlie I have made the changes to the files as per your suggestions. Kindly review them.

[engcom-Hotel]

@magento run all tests

[engcom-Charlie]

Hi @DhruvBasan,

Thank you for your contribution!

Did you get time to work on the build failures.

Thank you!

[engcom-Bravo]

Hello,

Internal team has started to work on it

Thanks.

[engcom-Bravo]

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-11798 by the internal team Related commits:https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-11798&type=commits

Based on the Jira ticket, the target version is 2.4.8-beta1.

Thanks