Check if OpenGraph can show price

[barryvdh]

Description (*)

This checks if the price can be shown

Manual testing scenarios (*)

• Create a plugin which hides the price, or use https://github.com/karliuka/m2.ProductAvailable
• Check that the price is hidden
• Check that without this change, the price is still visible in the OG tag.

Contribution checklist (*)

• [x] Pull request has a meaningful description of its purpose
• [x] All commits are accompanied by meaningful commit messages
• [ ] All new or changed code is covered with unit/integration tests (if applicable)
• [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

1. [x] resolves magento/magento2#38512: Check if OpenGraph can show price

[m2-assistant[bot]]

Hi @barryvdh. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

[barryvdh]

@magento run all tests

[engcom-Hotel]

@magento create issue

[barryvdh]

@magento run WebAPI Tests

[engcom-Hotel]

@magento run all tests

[barryvdh]

Hello @barryvdh,

Thanks for the contribution!

Please fix the failed static tests, other failed tests seems flaky to me.

Thanks

Do you mean this error?

That doesn't seem relevant to my PR, or do you need me to fix the rest of the template?

[engcom-Hotel]

Hello @barryvdh,

I agree that the failures are not related to your changes, but we need a green build to proceed further with this.

Thanks

[barryvdh]

@magento run static tests

[barryvdh]

@magento run all tests

[barryvdh]

@magento run all tests

[barryvdh]

@magento run all tests

[barryvdh]

@engcom-Hotel all good now?

[engcom-Hotel]

@magento run Functional Tests B2B, Functional Tests CE, Unit Tests

[engcom-Bravo]

@magento run all tests

[engcom-Bravo]

Hi @barryvdh,

Thanks for the collaboration & contribution!

:heavy_check_mark: QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

• Create a plugin which hides the price, or use https://github.com/karliuka/m2.ProductAvailable
• Check that the price is hidden
• Check that without this change, the price is still visible in the OG tag

Before: :heavy_multiplication_x: 

After: :heavy_check_mark:

price is not visible in the OG tag.

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Unit Tests, Functional Tests B2B, Functional Tests EE, Functional Tests CE

[engcom-Dash]

The consistent test failures for Functional B2B are known Issues and JIRA is raised for them. Other failures are inconsistent and seems to be flaky. They neither part of PR nor failing because of the PR changes.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38510/5ca8272b8857988043cdae955df852d5/Functional/allure-report-b2b/index.html#categories/ba729ce87e7059ef4466d4300850777a/722ee95bc7de6136/

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38510/d10ae97404e2930646afc457cebd1ed2/Functional/allure-report-b2b/index.html#categories/ba729ce87e7059ef4466d4300850777a/15276744294c5a42/

Known Issues: OrderWithMultipleConfigurableProductsAdditionalStockTest : ACQE-8060 EnablePaypalExpressCheckoutAndSubmitAnOrderUsingPaypalExpressCheckoutTest : ACQE-8007 StoreFrontSimpleProductWithSpecialAndTierDiscountPriceTest : ACQE-7971

The consistent test failure for Functional CE is known Issues and JIRA is raised for the same.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38510/ca591881f4de4023cba453a622039d61/Functional/allure-report-ce/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38510/2a15ee83cd96cf22a4fa170076e4bd6f/Functional/allure-report-ce/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Known Issues: EnablePaypalExpressCheckoutAndSubmitAnOrderUsingPaypalExpressCheckoutTest : ACQE-8007

[engcom-Dash]

The consistent test failure for Functional EE is known Issues and JIRA is raised for the same. Other failure is inconsistent and seems to be flaky. They neither part of PR nor failing because of the PR changes.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38510/b780ede4c5d83a4438f07e581d47f592/Functional/allure-report-ee/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38510/86e60bf286aaad1ca64bf0bcaaadb5e3/Functional/allure-report-ee/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Known Issues: EnablePaypalExpressCheckoutAndSubmitAnOrderUsingPaypalExpressCheckoutTest : ACQE-8007

Hence moving this PR in Merge In Progress.

[engcom-Dash]

@magento run all tests