magento2
magento2 copied to clipboard
Improvement: Added additional marketing tags to be excluded in Varnish configuration
Description
Improvement: Added additional marketing tags to be excluded in Varnish configuration
Fixed Issues (if relevant)
- Fixes magento/magento2#38298
Manual testing scenarios
- Go into the admin and export the varnish configuration to show the extra marketing tags to be excluded.
Contribution checklist (*)
- [x] Pull request has a meaningful description of its purpose
- [x] All commits are accompanied by meaningful commit messages
- [ ] All new or changed code is covered with unit/integration tests (if applicable)
- [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- [ ] All automated tests passed successfully (all builds are green)
Hi @CreamDevelopment. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:
@magento give me test instance- deploy test instance based on PR changes@magento give me 2.4-develop instance- deploy vanilla Magento instance
:exclamation: Automated tests can be triggered manually with an appropriate comment:
@magento run all tests- run or re-run all required tests against the PR changes@magento run <test-build(s)>- run or re-run specific test build(s) For example:@magento run Unit Tests
<test-build(s)> is a comma-separated list of build names.
Allowed build names are:
Database CompareFunctional Tests CEFunctional Tests EEFunctional Tests B2BIntegration TestsMagento Health IndexSample Data Tests CESample Data Tests EESample Data Tests B2BStatic TestsUnit TestsWebAPI TestsSemantic Version Checker
You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.
For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.
@CreamDevelopment, please sign CLA
@ihor-sviziev It has bene signed.
Maybe _kx can be added as well? It was proposed in https://github.com/magento/magento2/pull/36796/files#r1095535697, but that PR got closed unfortunately.
_kx seems to be related with Klaviyo: https://help.klaviyo.com/hc/en-us/articles/115005076767
@hostep I do agree, but we also have a separate fixes for that in https://github.com/magento/magento2/pull/35228, so I would just test these 2 Pull Requests together
@hostep @CreamDevelopment @ihor-sviziev maybe we can add a configuration field for this?
@peterjaap, I think it would be too complicated. I think having it like that should be enough