magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Improvement: Added additional marketing tags to be excluded in Varnish configuration

Open CreamDevelopment opened this issue 1 year ago • 5 comments
trafficstars

Description

Improvement: Added additional marketing tags to be excluded in Varnish configuration

Fixed Issues (if relevant)

  1. Fixes magento/magento2#38298

Manual testing scenarios

  1. Go into the admin and export the varnish configuration to show the extra marketing tags to be excluded.

Contribution checklist (*)

  • [x] Pull request has a meaningful description of its purpose
  • [x] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

CreamDevelopment avatar Dec 19 '23 12:12 CreamDevelopment

Hi @CreamDevelopment. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Dec 19 '23 12:12 m2-assistant[bot]

@CreamDevelopment, please sign CLA

ihor-sviziev avatar Dec 21 '23 07:12 ihor-sviziev

@ihor-sviziev It has bene signed.

CreamDevelopment avatar Dec 21 '23 14:12 CreamDevelopment

Maybe _kx can be added as well? It was proposed in https://github.com/magento/magento2/pull/36796/files#r1095535697, but that PR got closed unfortunately. _kx seems to be related with Klaviyo: https://help.klaviyo.com/hc/en-us/articles/115005076767

hostep avatar Jan 03 '24 14:01 hostep

@hostep I do agree, but we also have a separate fixes for that in https://github.com/magento/magento2/pull/35228, so I would just test these 2 Pull Requests together

ihor-sviziev avatar Jan 03 '24 14:01 ihor-sviziev

@hostep @CreamDevelopment @ihor-sviziev maybe we can add a configuration field for this?

peterjaap avatar Apr 02 '24 07:04 peterjaap

@peterjaap, I think it would be too complicated. I think having it like that should be enough

ihor-sviziev avatar Apr 02 '24 08:04 ihor-sviziev