Duplicate cache fpc for same page with same query

[rogerdz]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#38269

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• [ ] Pull request has a meaningful description of its purpose
• [ ] All commits are accompanied by meaningful commit messages
• [ ] All new or changed code is covered with unit/integration tests (if applicable)
• [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [ ] All automated tests passed successfully (all builds are green)

[m2-assistant[bot]]

Hi @rogerdz. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

[rogerdz]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[rogerdz]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[rogerdz]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[rogerdz]

@magento run all tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[rogerdz]

@magento run Integration Tests, WebAPI Tests

[magento-automated-testing[bot]]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Hotel]

@magento run all tests

[rogerdz]

@magento run all tests

[rogerdz]

@magento run all tests

[rogerdz]

@magento run all tests

[engcom-Hotel]

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests, Magento Health Index

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

Hi @rogerdz,

Thank you for working on Unit test failure. In order to move further on this PR, build should be green; can you please have a look into Magento Health Index failure.

[rogerdz]

@magento run all tests

[rogerdz]

Hi @engcom-Charlie, I fixed all test failed, Functional Tests fail seem not related my code

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, WebAPI Tests

[engcom-Hotel]

@magento run all tests

[rogerdz]

@magento run all tests

[engcom-Bravo]

@magento run all tests

[engcom-Bravo]

Hi @rogerdz,

Thanks for the collaboration & contribution!

:heavy_check_mark: QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

As per the Description.

Before: :heavy_multiplication_x: 

After: :heavy_check_mark:

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests CE

[engcom-Charlie]

The Functional B2B test failures are not consistent in recent 2 builds. They are neither part of PR now failing because of PR changes. Seems to be flaky, hence moving it to Merge in Progress.

Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38270/f751c6d7e59f68f664f9240db0474fcf/Functional/allure-report-b2b/index.html#categories/16b25a50b4a8b68f5548cdba82ebd5f8/65d76e88635b8175/

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38270/c84d5d0c039fd077a616edb568dd271b/Functional/allure-report-b2b/index.html#categories

[engcom-Charlie]

We have seen PAT failures in mainline PR after merging this PR into that. Hence for further analysis; for now moving this PR to Extended testing.