magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Published 20 hours ago • verified publisher icon magento

fix 38200: Exception is not getting handled properly while adding a product to cart in the compare product page

Open rogerdz opened this issue 1 year ago • 17 comments

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#38200

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

rogerdz avatar Dec 08 '23 16:12 rogerdz

Hi @rogerdz. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Dec 08 '23 16:12 m2-assistant[bot]

@magento run all tests

rogerdz avatar Dec 08 '23 16:12 rogerdz

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

magento-automated-testing[bot] avatar Dec 08 '23 16:12 magento-automated-testing[bot]

@magento run all tests

rogerdz avatar Dec 11 '23 03:12 rogerdz

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

magento-automated-testing[bot] avatar Dec 11 '23 03:12 magento-automated-testing[bot]

@magento run all tests

rogerdz avatar Dec 11 '23 09:12 rogerdz

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

magento-automated-testing[bot] avatar Dec 11 '23 09:12 magento-automated-testing[bot]

@magento run all tests

rogerdz avatar Dec 11 '23 15:12 rogerdz

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

magento-automated-testing[bot] avatar Dec 11 '23 15:12 magento-automated-testing[bot]

@magento run all tests

rogerdz avatar Dec 12 '23 04:12 rogerdz

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

magento-automated-testing[bot] avatar Dec 12 '23 04:12 magento-automated-testing[bot]

Hello @rogerdz Thank you for your contribution The changes look nice for but let's wait for integration test results. I've rerun it.

andrewbess avatar Jan 22 '24 12:01 andrewbess

@magento run Integration Tests

andrewbess avatar Jan 22 '24 13:01 andrewbess

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

magento-automated-testing[bot] avatar Jan 22 '24 13:01 magento-automated-testing[bot]

@magento run Functional Tests CE, Functional Tests EE

andrewbess avatar Jan 22 '24 15:01 andrewbess

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

magento-automated-testing[bot] avatar Jan 22 '24 15:01 magento-automated-testing[bot]

Hello,

Internal team has started to work on it

Thanks.

engcom-Bravo avatar May 21 '24 07:05 engcom-Bravo

For some reason, this PR wasn't marked as merged, even though the code was merged recently here: https://github.com/magento/magento2/commit/808253df82fcfa653e851ef0224ab33837b2ad65

hostep avatar Jul 03 '24 18:07 hostep

For some reason, this PR wasn't marked as merged, even though the code was merged recently here: 808253d

yes, it not first time :))

rogerdz avatar Jul 04 '24 02:07 rogerdz

@hostep Thanks for your contribution!!.

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-10660 by the internal team Related commits:https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-10660&type=commits

Based on the Jira ticket, the target version is 2.4.8-beta1.

Thanks

engcom-Bravo avatar Jul 04 '24 06:07 engcom-Bravo