magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Published 20 hours ago • verified publisher icon magento

Correct typo and grammar in acl.xsd file

Open mage2pratik opened this issue 2 years ago • 10 comments

Description (*)

This pull request corrects typo and incorrect grammar in the lib/internal/Magento/Framework/Acl/etc/acl.xsd file.

Related Pull Requests

This pull request changes only documentation strings and does not alter Magento behaviour. Therefore there is no special testing is required other than confirming that the previous typo/grammar was wrong, and the current grammar is correct.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

N/A

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

  1. [x] resolves magento/magento2#38061: Correct typo and grammar in acl.xsd file

mage2pratik avatar Oct 05 '23 19:10 mage2pratik

Hi @mage2pratik. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Oct 05 '23 19:10 m2-assistant[bot]

@magento create issue

engcom-Bravo avatar Oct 10 '23 11:10 engcom-Bravo

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

magento-automated-testing[bot] avatar Oct 20 '23 09:10 magento-automated-testing[bot]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

magento-automated-testing[bot] avatar Oct 27 '23 08:10 magento-automated-testing[bot]

@magento run all tests

engcom-Delta avatar Nov 23 '23 12:11 engcom-Delta

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

magento-automated-testing[bot] avatar Nov 23 '23 12:11 magento-automated-testing[bot]

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop

Manual testing scenario:

  1. Go to lib/internal/Magento/Framework/Acl/etc/acl.xsd
  2. Verify the acl.xsd
  3. Item id attribute can have only [a-z0-9/_]. Minimal length 3 symbol. Case insensitive

Before: ✖️

Screenshot 2023-11-23 at 3 53 49 PM

After: ✔️

Screenshot 2023-11-24 at 11 43 44 AM

Builds are failed. Hence, moving this PR to Extended Testing.

engcom-Delta avatar Nov 24 '23 06:11 engcom-Delta

@magento run all tests

engcom-Echo avatar Jul 16 '24 10:07 engcom-Echo

@magento run Functional Tests B2B ,Functional Tests EE ,Functional Tests CE

engcom-Echo avatar Jul 16 '24 12:07 engcom-Echo

Functional Tests EE,Functional Tests CE,Functional Tests B2B tests failure are different on last two run on same commit. And Also it contains some known failures. List of known failures. ACQE-6774 ACQE-6695 ACQE-6331 ACQE-6786 ACQE-6469

Functional Tests EE Run1 Screenshot 2024-07-16 at 6 56 05 PM

Run2 Screenshot 2024-07-17 at 10 19 46 AM

Functional Tests CE Run1 Screenshot 2024-07-16 at 6 55 56 PM

Run2 Screenshot 2024-07-17 at 10 19 41 AM

Functional Tests B2B Run1 Screenshot 2024-07-16 at 6 55 47 PM

Run2 Screenshot 2024-07-17 at 10 19 37 AM

Hence moving it to merge in progress

engcom-Echo avatar Jul 17 '24 04:07 engcom-Echo